78447[BUGFIX] DatabaseUpdatedPrerequisite returns correct ensure-state
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Thomas Hohn +1
- Markus Klein +1
-
Verified V +2 Done
- Stefan Bürk +2
- Markus Klein +1
- core-ci +1 CI
Issues 1
Files 1
Review log 2533
Show 68 earlier messages
-
Alexander Opitz uploaded patch set 1 04/04/23, 13:14
-
Oliver Klee updated the commit message in patch set 2 04/04/23, 13:32
-
core-ci voted on patch set 1 V +1 04/04/23, 13:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40089
-
core-ci voted on patch set 2 V +1 04/04/23, 13:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40091
-
Oliver Klee commented on patch set 2 04/04/23, 14:00
-
Alexander Opitz uploaded patch set 3
V +104/05/23, 12:20 -
Alexander Opitz updated the commit message in patch set 4 04/05/23, 12:21
-
Alexander Opitz commented on patch set 4 04/05/23, 12:22
DatabaseUpdatedPrerequisite.php:58ReplyDone
-
core-ci voted on patch set 3 V -1 04/05/23, 13:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40184
-
core-ci voted on patch set 4 V -1 04/05/23, 13:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40185
-
Oliver Klee commented on patch set 4 04/05/23, 15:47
Maybe we can extract the cleanup into a pre-patch (so both changes are more focused). Should I take care of the pre-patch? -
Oliver Klee commented on patch set 4 CR -1 04/05/23, 21:35
I have created the pre-patch: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78497 -
Oliver Klee commented on patch set 4 CR 0 04/07/23, 12:01
The pre-patch now has been merged, and this change should be rebased. -
Oliver Klee uploaded patch set 5
V -104/07/23, 12:43 -
core-ci voted on patch set 5 V +1 04/07/23, 12:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40335
-
Stefan Bürk commented on patch set 5 CR -1 04/08/23, 13:39
DatabaseUpdatedPrerequisite.php:53Would say, use a variable before the if for it. That way, we can avoid the recount in 54 (side change)DatabaseUpdatedPrerequisite.php:61we can add a break here, as we only need "one" non empty error to set the ensured to false. no need to check for further errors. (early break). -
Oliver Klee commented on patch set 5 04/08/23, 17:02
DatabaseUpdatedPrerequisite.php:49I'd like to propose a rename: `$result` -> `$errorMessages`DatabaseUpdatedPrerequisite.php:53ReplyOr even better, we do an early return: ```php // If there is nothing to add, there cannot be any errors from the adds. if ($adds === []) { return; } ```DatabaseUpdatedPrerequisite.php:61ReplyOr even shorter: We `implode` all error messages, and if the result is not an empty string, we have at least one error. -
Alexander Opitz commented on patch set 5 04/11/23, 07:12
DatabaseUpdatedPrerequisite.php:61ReplyIf, say 10, Statements fail, this complete error messages would be combined to one string ... messing around with memory. Something I don't like. :-/ -
Thomas Hohn uploaded patch set 6
CR -1V +104/28/23, 12:31 -
core-ci voted on patch set 6 V +1 04/28/23, 12:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41295
-
Oliver Klee commented on patch set 6 04/28/23, 13:10
DatabaseUpdatedPrerequisite.php:49ReplyDoneDatabaseUpdatedPrerequisite.php:53ReplyDone -
Thomas Hohn commented on patch set 6 04/29/23, 05:25
DatabaseUpdatedPrerequisite.php:61ReplyDone -
Stefan Bürk updated the commit message in patch set 7
V +104/30/23, 08:33 -
Oliver Klee voted on patch set 7 CR +1 04/30/23, 13:41
-
Thomas Hohn rebased onto patch set 8
CR +105/02/23, 11:38 -
core-ci voted on patch set 8 V +1 05/02/23, 11:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41346
-
Benni Mack updated the commit message in patch set 9
V +105/03/23, 09:50 -
Markus Klein uploaded patch set 10 06/13/23, 07:26
-
Thomas Hohn voted on patch set 10 CR +1 06/13/23, 07:31
-
Markus Klein voted on patch set 10 V +1 CR +1 06/13/23, 07:33
-
core-ci voted on patch set 10 V +1 06/13/23, 07:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42431
-
Stefan Bürk voted on patch set 10 V +2 CR +2 06/14/23, 12:23
-
Stefan Bürk merged patch set 11 06/14/23, 12:23
DatabaseUpdatedPrerequisite.php:58