Review main Merged

78448[TASK] Update bootstrap to 5.3.0-alpha3

Benjamin Kott CR +2 V +2 Expert +657 −559 updated 04/14/23, 16:35

Commit message

- Drop default override styling for <hr> without classes
- Drop unused/obsolete scss variables
- Drop variable `$text-color` in favor of `$body-color`.
- Drop class `.text-muted` in favor of `.text-body-secondary`
- Drop class `.form-inline` from usage in the backend
- Icons are now displayed correctly next to text for login provider

Note: Some spacings were hotfixed for now.
It is planned to clean the `mb-*` classes up at a later point.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Jasmina Ließmann +1
  • Verified V +2 Done
    • Benni Mack +2
    • Jasmina Ließmann +1
    • core-ci +1 CI

Issues 1

Files 61

Show 41 more files

Review log 2742

Show 1217 earlier messages
  1. Benjamin Kott uploaded patch set 1 04/04/23, 13:16

  2. core-ci voted on patch set 1 V -1 04/04/23, 13:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40090

  3. Benjamin Kott uploaded patch set 2 V -1 04/04/23, 13:41

  4. core-ci voted on patch set 2 V +1 04/04/23, 13:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40092

  5. Benni Mack voted on patch set 2 V +1 CR +1 04/04/23, 15:15

  6. Andreas Kienast voted on patch set 2 V +1 CR +1 04/04/23, 15:30

  7. Christian Kuhn commented on patch set 2 04/04/23, 16:37

    Are there any notable changes we should know? Something that has been systematically adapted and changed with the patch, for instance in the consuming html?
  8. Benni Mack commented on patch set 2 04/05/23, 06:10

    Reply

    I usually follow their announcements / blogs and scan for notable changes. they "deprecate" things but without deprecation notice when having the CSS classes, and this is a non-breaking release, so we're good on that. I would really like to have the latest 5.x of this series in Core in order to ease further upgrades.
  9. Benjamin Kott commented on patch set 2 CR -1 04/05/23, 07:09

    - will trim the patch a bit, contains some driveby fixes i will extract
  10. Christian Kuhn commented on patch set 2 04/05/23, 08:25

    Reply

    yeah. i was more trying to trigger the casual "no commit message on such a change" problem: maybe link the changelogs and point out the most important things that typicyally affect us?
  11. Benni Mack commented on patch set 2 04/05/23, 08:47

    Reply

    agreed.
  12. Benjamin Kott uploaded patch set 3 CR +1 V +1 04/05/23, 10:35

  13. core-ci voted on patch set 3 V +1 04/05/23, 10:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40176

  14. Benjamin Kott uploaded patch set 4 V +1 04/05/23, 11:07

  15. core-ci voted on patch set 4 V +1 04/05/23, 11:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40180

  16. Benjamin Kott uploaded patch set 5 V +1 04/06/23, 09:03

  17. core-ci voted on patch set 5 V +1 04/06/23, 09:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40249

  1. Benjamin Kott uploaded patch set 6 V +1 04/06/23, 09:40

  2. Benni Mack commented on patch set 6 04/06/23, 09:45

    _legacy.scss:86

    form-control-feedback can be removed as well
  3. core-ci voted on patch set 6 V +1 04/06/23, 10:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40262

  4. Benjamin Kott uploaded patch set 7 V +1 04/06/23, 13:44

  5. Benjamin Kott uploaded patch set 8 04/06/23, 13:47

  6. core-ci voted on patch set 8 V +1 04/06/23, 13:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40297

  7. core-ci voted on patch set 7 V +1 04/06/23, 14:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40296

  8. Benjamin Kott uploaded patch set 9 V +1 04/07/23, 14:04

  9. core-ci voted on patch set 9 V +1 04/07/23, 15:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40346

  10. Benjamin Kott uploaded patch set 10 V +1 04/13/23, 13:26

  11. core-ci voted on patch set 10 V +1 04/13/23, 13:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40569

  12. Benjamin Kott uploaded patch set 11 V +1 04/14/23, 12:16

  13. core-ci voted on patch set 11 V +1 04/14/23, 12:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40615

  14. Benjamin Kott uploaded patch set 12 V +1 04/14/23, 12:41

  15. core-ci voted on patch set 12 V +1 04/14/23, 12:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40619

  16. Benjamin Kott uploaded patch set 13 V +1 04/14/23, 13:33

  17. Benjamin Kott uploaded patch set 14 04/14/23, 13:46

  18. Benjamin Kott commented on patch set 13 04/14/23, 13:46

    _legacy.scss:86 Reply

    Done
  19. core-ci voted on patch set 13 V +1 04/14/23, 13:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40622

  20. core-ci voted on patch set 14 V +1 04/14/23, 13:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40624

  21. Benjamin Kott uploaded patch set 15 V +1 04/14/23, 14:18

  22. core-ci voted on patch set 15 V +1 04/14/23, 14:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40626

  23. Jasmina Ließmann voted on patch set 15 V +1 CR +1 04/14/23, 16:30

  24. Benni Mack voted on patch set 15 V +2 CR +2 04/14/23, 16:35

  25. Benni Mack merged patch set 16 04/14/23, 16:35