Review main Merged

78449[BUGFIX] Remove invalid attributes on icon component usages

Benjamin Kott CR +2 V +2 Normal +39 −39 updated 04/05/23, 13:34

Commit message

The css classes icon and icon-size-small are unnessesary since the
size property already sets and uses the correct internal classes.

The attribute alternativeMarkupIdentifier does not exist.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Markus Klein +1
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Markus Klein +1
    • core-ci +1 CI

Issues 1

Files 8

Review log 78

  1. Benjamin Kott uploaded patch set 1 04/04/23, 14:04

  2. core-ci voted on patch set 1 V +1 04/04/23, 14:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40093

  3. Benni Mack voted on patch set 1 CR +1 04/04/23, 14:18

  4. Andreas Kienast voted on patch set 1 CR +1 04/04/23, 15:11

  5. Markus Klein voted on patch set 1 CR +1 04/05/23, 11:06

  6. Markus Klein voted on patch set 1 V +1 04/05/23, 11:43

  7. Christian Kuhn voted on patch set 1 V +2 CR +2 04/05/23, 13:34

  8. Christian Kuhn merged patch set 2 04/05/23, 13:34