Review main Merged

78460[TASK] Declare all test classes final

Wouter Wolters CR +2 V +2 Expert +1303 −1083 updated 04/11/23, 09:42

Commit message

Test classes should never extend each other.
phpunit 10 is also a bit more picky about naming
of abstract test cases.

The patch adds a script to verify all test case
files are declared final, adds it to CI, and
adapts existing tests accordingly.

> Build/Scripts/runTests.sh -s checkTestClassFinal

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 1089

Show 1069 more files