Review main Merged

78466[TASK] Raise 'phpstan/phpstan' and regenerate baseline file

Stefan Bürk CR +2 V +2 Easy +26 −18 updated 04/05/23, 05:55

Commit message

PHPStan recenently released a new patchlevel version,
fixing the one or other bug and changing the reported
issue message texts.

This change raises the phpstan dependency along with
one extending package. The baseline file was regenerated to
update to new message texts of some reported messages
to mitigate issue flipping between composer locked and
composer max testing.

Used command(s):

> composer require --dev \
    "phpstan/phpstan":"^1.10.11" \
    "phpstan/phpstan-phpunit":"^1.3.11"

> ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Chris Müller +1
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Chris Müller +1
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 913

  1. Stefan Bürk uploaded patch set 1 04/05/23, 02:42

  2. Stefan Bürk updated the commit message in patch set 2 04/05/23, 02:48

  3. Stefan Bürk updated the commit message in patch set 3 04/05/23, 02:48

  4. core-ci voted on patch set 3 V +1 04/05/23, 02:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40141

  5. core-ci voted on patch set 3 V -1 04/05/23, 03:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40144

  6. Stefan Bürk commented on patch set 3 04/05/23, 04:20

    nightly AC test hickup (-1) - retry started
  7. core-ci voted on patch set 3 V +1 04/05/23, 04:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40144

  8. Anja Leichsenring updated the commit message in patch set 4 V +1 04/05/23, 05:01

  9. core-ci voted on patch set 4 V +1 04/05/23, 05:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40148

  10. Anja Leichsenring voted on patch set 4 V +1 CR +1 04/05/23, 05:17

  11. Chris Müller voted on patch set 4 V +1 CR +1 04/05/23, 05:25

  12. Andreas Kienast voted on patch set 4 V +2 CR +2 04/05/23, 05:55

  13. Andreas Kienast merged patch set 5 04/05/23, 05:55