78470[BUGFIX] Do not use native attributes in typo3-notification-message
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Markus Klein +1
-
Verified V +2 Done
- Andreas Kienast +2
- Markus Klein +1
- core-ci +1 CI
Issues 1
Files 2
Review log 89
-
Benjamin Kott uploaded patch set 1 04/05/23, 07:47
-
core-ci voted on patch set 1 V +1 04/05/23, 07:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40157
-
Markus Klein commented on patch set 1 CR +1 04/05/23, 11:42
how to test this the easiest? -
Andreas Kienast voted on patch set 1 V +1 CR +1 04/05/23, 13:38
-
Andreas Kienast commented on patch set 1 04/05/23, 13:39
Reply
Without patch applied: trigger a notification (e.g. via EXT:styleguide) and hover over the notification. You'll see a title "popup" having the notification title. -
Markus Klein voted on patch set 1 V +1 04/05/23, 15:27
-
Markus Klein commented on patch set 1 04/05/23, 15:27
Reply
Done -
Andreas Kienast voted on patch set 1 V +2 CR +2 04/06/23, 07:44
-
Andreas Kienast merged patch set 2 04/06/23, 07:44