Review main Merged

78475[BUGFIX] Drop input-group-btn usages if possible

Benjamin Kott CR +2 V +2 Normal +40 −94 updated 04/06/23, 07:40

Commit message

The class input-group-btn was removed in bootstrap 4.6, we are now
dropping leftover usages. There is still a leftover in the form
framework rendering we cannot remove that easily. We are keeping
it as is for now since it would require refactoring of the form
javascript.

The other place in combination with typo3-mfa-totp-url-info-button
is handled in a dedicated patch.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 16

Review log 68

  1. Benjamin Kott uploaded patch set 1 04/05/23, 10:57

  2. Benjamin Kott updated the commit message in patch set 2 04/05/23, 10:58

  3. core-ci voted on patch set 1 V +1 04/05/23, 11:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40178

  4. core-ci voted on patch set 2 V +1 04/05/23, 11:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40179

  5. Andreas Kienast voted on patch set 2 V +1 CR +1 04/05/23, 14:18

  6. Benni Mack voted on patch set 2 V +1 CR +1 04/06/23, 07:40

  7. Benni Mack voted on patch set 2 V +2 CR +2 04/06/23, 07:40

  8. Benni Mack merged patch set 3 04/06/23, 07:40