Review main Merged

78480[TASK] Remove BackendModuleControllerTest

Christian Kuhn CR +2 V +2 Normal +0 −117 updated 04/05/23, 15:23

Commit message

This test is tricky since the subject triggers
session_save_path() which is limited to one
call per php process and emits a warning when
called multiple times.

This was mitigated by adding an own exception
handler in the test setup, but this solution
fails with phpunit 10, which is more picky
and can't be tricked easily.

The value added by the test is not *that*
high and the overall setup is complex, so
in this case, it's better to remove the test.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 1