Review main Merged

78482[TASK] Adjust attributes of ColumnSelectorButton

Oli Bartsch CR +2 V +2 Normal +32 −32 updated 04/06/23, 20:09

Commit message

This replaces usage of native attributes for
custom properties to avoid unintended side
effects.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 67

  1. Oli Bartsch uploaded patch set 1 04/05/23, 15:09

  2. core-ci voted on patch set 1 V +1 04/05/23, 15:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40198

  3. Benni Mack voted on patch set 1 CR +1 04/05/23, 21:01

  4. Jochen Roth voted on patch set 1 V +1 CR +1 04/06/23, 08:40

  5. Benni Mack voted on patch set 1 V +1 04/06/23, 11:43

  6. Oli Bartsch voted on patch set 1 V +2 CR +2 04/06/23, 20:09

  7. Oli Bartsch merged patch set 2 04/06/23, 20:09