Review main Merged

78485[BUGFIX] Correct treelist-renderings

Benjamin Kott CR +2 V +2 Hard +471 −450 updated 04/07/23, 13:40

Commit message

This is the first step to correct the CSS list-tree. Even it is
documented in the style guide extension it was managed to have
several kinds of implementation through the core.

To make it clear and force people to look up the actual use, we are
now also streamlining the naming scheme.

Old: .list-tree
New: .treelist

This led to a misplacement of the open/collapsed indicator/toggle
of tree branches. The control element was somehow moved inside the
treelist-group, which is purely intended to handle a single row of
informational content. In addition collapse classes were mixed up
with tree stylings, which lead to cut-off indicators, and sluggish
opening and close animations.

Helpers to make tables responsive where used out of place to achieve
similar but different behavior for panels that are intended to
overflow if the content is too long.

The diff component was used in an unintended space and was not
used as documented. That made manual adaptions necessary that now
have been revoked. Instead, we now only apply the table structure
only if the nesting is correct. So the parts of the component can
be used in other places for now. While we are here, we are adapting
and streamlining the colors of the diff component.

All randomly placed text-monospace classes were removed from the
table rendering and are now only applied to the information group
if necessary. This avoids having badges, buttons, etc restyled
to a monospace font.

The styling adaptions in the import/export module were incomplete
and several necessary corrections were missing. We now made it
easier to define the background color for the element.

Misplaced control CSS classes that seem to be leftovers have been
removed from elements they don`t belong to.

As mentioned, this patch is part of the ongoing cleanup and has no
intention to be finished or solve all the remaining issues.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 25

Show 5 more files