Review main Merged

78488[TASK] Improve WebhookExecutionTest

Christian Kuhn CR +2 V +2 Normal +90 −25 updated 04/05/23, 19:28

Commit message

This test case of ext:webhooks is a bit weird.

The patch relaxes this a bit: Extending a
ext:core abstract is avoided, the setup is
streamlined, and abusing ext:core fixture
files is avoided.

With phpunit 10, one of the three tests fails,
probably because its broken, but the details
are unclear. It's marked as skipped for now.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 5