Review main Merged

78496[TASK] Respect REDIRECT_* env variables

Benni Mack CR +2 V +2 Easy +16 −7 updated 04/16/23, 15:09

Commit message

When using TYPO3_PATH_ROOT and TYPO3_PATH_APP from
apache/modules, the prefix is usually "REDIRECT_",
so this also needs to be checked for both environment
variables, as already done in TYPO3_CONTEXT.

Typical use-case is by setting this via .htaccess
rules.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1320

  1. Benni Mack uploaded patch set 1 04/05/23, 21:12

  2. core-ci voted on patch set 1 V -1 04/05/23, 21:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40221

  3. Christian Kuhn uploaded patch set 2 V -1 04/15/23, 20:40

  4. core-ci voted on patch set 2 V -1 04/15/23, 20:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40710

  5. Stefan Bürk uploaded patch set 3 V -1 04/15/23, 22:16

  6. Stefan Bürk uploaded patch set 4 04/15/23, 22:17

  7. Christian Kuhn uploaded patch set 5 04/15/23, 22:30

  8. core-ci voted on patch set 3 V -1 04/15/23, 22:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40715

  9. core-ci voted on patch set 4 V -1 04/15/23, 22:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40716

  10. core-ci voted on patch set 5 V +1 04/15/23, 22:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40718

  11. Christian Kuhn commented on patch set 5 CR -1 04/15/23, 22:48

    still needs details with types.
  12. Stefan Bürk uploaded patch set 6 CR -1 V +1 04/15/23, 22:53

  13. Stefan Bürk commented on patch set 6 CR -1 04/15/23, 22:53

    Reply

    reapply -1 for now
  14. core-ci voted on patch set 6 V +1 04/15/23, 23:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40720

  15. Stefan Bürk uploaded patch set 7 CR -1 V +1 04/16/23, 14:51

  16. Christian Kuhn voted on patch set 7 V +1 CR +1 04/16/23, 14:52

  17. Stefan Bürk voted on patch set 7 V +1 CR +1 04/16/23, 14:53

  18. core-ci voted on patch set 7 V +1 04/16/23, 14:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40746

  19. Stefan Bürk voted on patch set 7 V +2 CR +2 04/16/23, 15:09

  20. Stefan Bürk merged patch set 8 04/16/23, 15:09