Review main Merged

78508[BUGFIX] Correct spacing in CSP configuration status callout

Benjamin Kott CR +2 V +2 Easy +8 −4 updated 04/06/23, 13:52

Commit message

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oliver Hader +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Oliver Hader +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1113

  1. Benjamin Kott uploaded patch set 1 04/06/23, 09:21

  2. core-ci voted on patch set 1 V +1 04/06/23, 09:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40254

  3. Oliver Hader commented on patch set 1 04/06/23, 09:50

    I'm unable to spot a difference (but that's my problem, because I'm just a dev). I guess the problem is the same with the `customReporting` section below? (triggered when using a custom URL in `contentSecurityPolicyReportingUrl` system settings)
  4. Benjamin Kott commented on patch set 1 04/06/23, 11:51

    Reply

    spacing between, text and list introduced, list margin to bottom removed.
  5. Andreas Kienast voted on patch set 1 V +1 CR +1 04/06/23, 11:51

  6. Oliver Hader commented on patch set 1 V +1 04/06/23, 12:12

    CspModule.html:52

    This section here is quite similar...
  7. Oliver Hader uploaded patch set 2 CR +1 V +1 04/06/23, 13:38

  8. Oliver Hader commented on patch set 2 V +1 CR +1 04/06/23, 13:38

    CspModule.html:52 Reply

    Done
  9. Oliver Hader commented on patch set 2 04/06/23, 13:38

    Reply

    Ack
  10. Andreas Kienast voted on patch set 2 V +1 CR +1 04/06/23, 13:40

  11. core-ci voted on patch set 2 V +1 04/06/23, 13:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40295

  12. Andreas Kienast voted on patch set 2 V +2 CR +2 04/06/23, 13:52

  13. Andreas Kienast merged patch set 3 04/06/23, 13:52