Review main Merged

78510[BUGFIX] Cast site identifier to string in MigrateSiteSettingsConfigUpdate

Oli Bartsch CR +2 V +2 Easy +2 −0 updated 04/06/23, 10:09

Commit message

Using typecast, we now properly ensure, the site
identifier is always a string, even if it only consists
of digits.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Oliver Klee +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 67

  1. Oli Bartsch uploaded patch set 1 04/06/23, 09:28

  2. Jochen Roth voted on patch set 1 V +1 CR +1 04/06/23, 09:35

  3. Oliver Klee voted on patch set 1 CR +1 04/06/23, 09:53

  4. core-ci voted on patch set 1 V +1 04/06/23, 10:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40259

  5. Christian Kuhn voted on patch set 1 V +1 CR +1 04/06/23, 10:05

  6. Oli Bartsch voted on patch set 1 V +2 CR +2 04/06/23, 10:08

  7. Oli Bartsch merged patch set 2 04/06/23, 10:09