Review main Merged

78514[TASK] Clean up fixCopyAfterDuplFields

Oli Bartsch CR +2 V +2 Easy +14 −17 updated 04/06/23, 18:47

Commit message

Rarely used fixCopyAfterDuplFields method in
DataHandler is cleaned up, since a couple of
arguments and options do no longer work due
to previous removals. Actually the method is
meanwhile only called once.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 810

  1. Oli Bartsch uploaded patch set 1 04/06/23, 10:06

  2. core-ci voted on patch set 1 V +1 04/06/23, 10:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40265

  3. Christian Kuhn commented on patch set 1 04/06/23, 10:56

    DataHandler.php:8774

    maybe protected along the way?

    DataHandler.php:8785

    you're sure it's fine we now rely on the parent method to perform the field updates? no chance for some side-effect or chicken-egg issue?
  4. Oli Bartsch uploaded patch set 2 V +1 04/06/23, 11:35

  5. Oli Bartsch commented on patch set 2 04/06/23, 11:36

    DataHandler.php:8774 Reply

    Done

    DataHandler.php:8785 Reply

    The method is called only once and previously had $update set to FALSE. Therefore this was never executed.
  6. Benni Mack commented on patch set 2 04/06/23, 11:39

    DataHandler.php:8784

    updateDB() is gone?
  7. core-ci voted on patch set 2 V +1 04/06/23, 11:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40279

  8. Benni Mack commented on patch set 2 V +1 CR +1 04/06/23, 13:37

    Fine. Thanks!

    DataHandler.php:8784 Reply

    Done
  9. Christian Kuhn commented on patch set 2 V +2 CR +2 04/06/23, 18:47

    DataHandler.php:8785 Reply

    Ah, missed that. Thx!
  10. Christian Kuhn merged patch set 3 04/06/23, 18:47