Review main Merged

78518[BUGFIX] Prevent undefined array key in TypolinkSoftReferenceParser

Oli Bartsch CR +2 V +2 Easy +1 −1 updated 04/06/23, 18:01

Commit message

Due to an invalid page link, e.g. "t3://page?type=123",
the "pageuid" key might not be set by PageLinkHandler.

This is now properly handled in the parser.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 910

  1. Oli Bartsch uploaded patch set 1 04/06/23, 10:48

  2. Christian Kuhn voted on patch set 1 V +1 CR +1 04/06/23, 10:50

  3. Stefan Bürk commented on patch set 1 04/06/23, 10:52

    TypolinkSoftReferenceParser.php:115

    Would it make sense to guard this uid also ?
  4. Oliver Klee voted on patch set 1 CR +1 04/06/23, 11:03

  5. core-ci voted on patch set 1 V +1 04/06/23, 11:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40275

  6. Oli Bartsch commented on patch set 1 04/06/23, 11:30

    TypolinkSoftReferenceParser.php:115 Reply

    Nope, RecordLinkHandler will throw an exception in case `uid` is not set.
  7. Oliver Hader voted on patch set 1 CR +1 04/06/23, 12:19

  8. Stefan Bürk voted on patch set 1 V +1 CR +1 04/06/23, 16:48

  9. Christian Kuhn voted on patch set 1 V +2 CR +2 04/06/23, 18:01

  10. Christian Kuhn merged patch set 2 04/06/23, 18:01