Review main Merged

78519[TASK] Slightly improve belog rendering

Benjamin Kott CR +2 V +2 Hard +131 −132 updated 04/07/23, 12:58

Commit message

We are introducing new table columns for avatar, time and datetime
in preparation for more adoptions. The avatar column also removes the
space on the right to bring it closer to the name of the user while
having a fixed size for medium avatars.

To avoid column jumping we also limit the size of the icon column to
the width of a small icon that is normally used in the tables in the
backend. The new time and datetime column classes are utilizing the
character unit and ensuring that the value is not wrapped to ensure a
better reading experience across multiple tables.

The button sizes in the table are now aligned with the list module and
the delete actions now feature an icon in addition to the text.

- Unnecessary/meaningless table headers for actions and icons are
  removed
- Unnecessary div blocks for the grouped log entries are removed.
- Unnecessary invisible divider was removed

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Jasmina Ließmann +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Jasmina Ließmann +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 1115

  1. Benjamin Kott uploaded patch set 1 04/06/23, 11:13

  2. core-ci voted on patch set 1 V +1 04/06/23, 11:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40276

  3. Oliver Klee updated the commit message in patch set 2 V +1 04/06/23, 11:36

  4. Andreas Kienast updated the commit message in patch set 3 04/06/23, 11:41

  5. Andreas Kienast voted on patch set 3 V +1 CR +1 04/06/23, 11:43

  6. core-ci voted on patch set 2 V +1 04/06/23, 12:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40280

  7. Andreas Kienast rebased onto patch set 4 CR +1 V +1 04/06/23, 12:19

  8. Andreas Kienast voted on patch set 4 V +1 CR +1 04/06/23, 12:20

  9. core-ci voted on patch set 3 V +1 04/06/23, 12:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40281

  10. core-ci voted on patch set 4 V +1 04/06/23, 12:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40285

  11. Markus Klein commented on patch set 4 04/07/23, 08:24

    LogEntries.html:24

    I would prefer: `<th><f:translate key="{f:if(condition: pageId, then: 'chLog_l_table', else: 'chLog_l_level')"/></th>`
  12. Benjamin Kott commented on patch set 4 04/07/23, 12:15

    LogEntries.html:24 Reply

    it just looks strange, but it is kept as it was before. not part of the patch.
  13. Jasmina Ließmann voted on patch set 4 V +1 CR +1 04/07/23, 12:48

  14. Andreas Kienast voted on patch set 4 V +2 CR +2 04/07/23, 12:58

  15. Andreas Kienast merged patch set 5 04/07/23, 12:58