78523[TASK] Drop special styling for popover, tooltips, h1, h2 and h3
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Georg Ringer +1
- Markus Klein +1
-
Verified V +2 Done
- Andreas Kienast +2
- Georg Ringer +1
- Markus Klein +1
- core-ci +1 CI
Issues 1
Files 33
- Build/Sources/Sass/component/_statusreport.scss+1 −0
- Build/Sources/Sass/typo3/_element_popover.scssdeleted+0 −45
- Build/Sources/Sass/typo3/_element_tooltip.scssdeleted+0 −6
- Build/Sources/Sass/typo3/_main_content.scss+0 −8
- Build/Sources/Sass/typo3/_main_type.scss+0 −8
- Build/Sources/Sass/variables/_main.scss+0 −1
- Build/Sources/Sass/backend.scss+0 −2
- Build/Sources/Sass/_legacy.scss+0 −1
- typo3/sysext/backend/Classes/Controller/RecordListController.php+1 −1
- typo3/sysext/backend/Resources/Private/Partials/PageLayout/LanguageColumns.html+1 −1
- typo3/sysext/backend/Resources/Private/Templates/PageTsConfig/Active.html+2 −4
- typo3/sysext/backend/Resources/Private/Templates/PageTsConfig/Includes.html+1 −3
- typo3/sysext/backend/Resources/Private/Templates/PageTsConfig/RecordsOverview.html+1 −3
- typo3/sysext/backend/Resources/Public/Css/backend.css+2 −14
- typo3/sysext/beuser/Resources/Private/Templates/Permission/Edit.html+1 −1
- typo3/sysext/indexed_search/Resources/Private/Templates/Administration/Index.html3+1 −1
- typo3/sysext/indexed_search/Resources/Private/Templates/Administration/StatisticDetails.html+1 −1
- typo3/sysext/indexed_search/Resources/Private/Templates/Administration/WordDetail.html+1 −3
- typo3/sysext/install/Resources/Private/Templates/Upgrade/ExtensionScanner.html+1 −1
- typo3/sysext/linkvalidator/Resources/Private/Templates/Backend/Report.html3+1 −1
Show 13 more files
- typo3/sysext/lowlevel/Classes/Controller/DatabaseIntegrityController.php+1 −1
- typo3/sysext/lowlevel/Resources/Private/Templates/ReferenceIndex.html+1 −1
- typo3/sysext/reports/Resources/Private/Templates/StatusReport.html+1 −1
- typo3/sysext/scheduler/Resources/Private/Templates/CheckScreen.html+1 −3
- typo3/sysext/scheduler/Resources/Private/Templates/InfoScreen.html+3 −3
- typo3/sysext/tstemplate/Resources/Private/Partials/ActiveOptions.html+1 −1
- typo3/sysext/tstemplate/Resources/Private/Templates/ActiveMain.html+1 −1
- typo3/sysext/tstemplate/Resources/Private/Templates/Analyzer.html+1 −3
- typo3/sysext/tstemplate/Resources/Private/Templates/ConstantEditorMain.html+1 −3
- typo3/sysext/tstemplate/Resources/Private/Templates/ConstantEditorNoTemplate.html+1 −3
- typo3/sysext/tstemplate/Resources/Private/Templates/InfoModifyMain.html+1 −3
- typo3/sysext/tstemplate/Resources/Private/Templates/InfoModifyNoTemplate.html+1 −3
- typo3/sysext/tstemplate/Resources/Private/Templates/TemplateRecordsOverview.html+33 −35
Review log 2228
Show 23 earlier messages
-
Benjamin Kott uploaded patch set 1 04/06/23, 13:31
-
core-ci voted on patch set 1 V +1 04/06/23, 13:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40293
-
Andreas Kienast voted on patch set 1 CR +1 04/06/23, 14:20
-
Jasmina Ließmann commented on patch set 1 04/06/23, 17:40
Fine for me except: 1 / Is there a similar replacement for 'text-monospace' that can be used for the page TSconfig code inside the module? If not then I would be in favor of keeping the classes in the "typo3/sysext/backend/Resources/Private/Templates/PageTsConfig/Active.html" file. 2 / The introductory text p.lead now sticks too much to the following content. This could be solved by adding the "mb-3" class (on all occurrences), but I would be in favor of keeping the custom style for this paragraph. -
Benjamin Kott uploaded patch set 2
CR +1V +104/07/23, 08:22 -
Benjamin Kott commented on patch set 1 04/07/23, 08:26
Reply
Remarks: 1. You are right, this is a rebase error - the text-monospace classes are removed in a dedicated patch without replacement see https://review.typo3.org/c/Packages/TYPO3.CMS/+/78485 2. You are right about the lead, but its less about the spacing lead consumes but more about the spacing h1 generated. I also removed almost all .lead ocurrances and replaced them with normal paragraphs or an h2 where it was misused. If we want to group and make space between elements we need to introduce a header-section or something that makes up the space explitilty but it is bad practice to have random spacings for the default elements. -
Benjamin Kott commented on patch set 2 04/07/23, 08:26
Reply
Ack -
core-ci voted on patch set 2 V +1 04/07/23, 08:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40326
-
Jasmina Ließmann commented on patch set 2 V -1 CR -1 04/07/23, 11:28
Reply
Thanks for restoring the text-monospace class! :) I disagree with removing the .lead class in the introductory text and making it a normal paragraph. The distance between the introductory text and the following elements is therefore too small. Likewise, the text can no longer be distinguished from the labels of possible subsequent form fields. The larger font also provided a good introduction to the respective module. Please see screenshots of several examples in the forge ticket. Maybe we can develop an alternative solution for headers in a separate patch. Until then, I'm in favor of keeping the styles of the class and using them in HTML and against removing them. -
Jasmina Ließmann commented on patch set 2 V 0 CR 0 04/07/23, 12:12
Reply
As just discussed/written privately: I'm removing my -1 for this patch and preparing a separate patch with a new header component (markup/styling) to render the intro section, once this patch was merged. -
Benjamin Kott uploaded patch set 3
V +104/07/23, 12:15 -
core-ci voted on patch set 3 V +1 04/07/23, 12:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40333
-
Benjamin Kott uploaded patch set 4
V +104/07/23, 14:00 -
core-ci voted on patch set 4 V +1 04/07/23, 14:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40344
-
Markus Klein commented on patch set 4 04/07/23, 20:42
Index.html:11not sure if a description really qualifies as a h2 maybe going with p.h2 would be better? -
Markus Klein commented on patch set 4 04/07/23, 20:44
Report.html:17that's used in linkvalidator.ts, or am I missing something? -
Benjamin Kott commented on patch set 4 04/08/23, 13:17
Index.html:11Replyi would agree, when the contents would not be "General statistics"Report.html:17Replyyou may are right, did not find any usages will check again! -
Benjamin Kott uploaded patch set 5
V +104/08/23, 13:19 -
Benjamin Kott commented on patch set 5 04/08/23, 13:20
Report.html:17Replyadded it again, it is still used -
Markus Klein commented on patch set 5 04/08/23, 13:47
Index.html:11Replyoh dear. alright then -
Markus Klein voted on patch set 5 V +1 CR +1 04/08/23, 13:47
-
core-ci voted on patch set 5 V +1 04/08/23, 13:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40372
-
Benjamin Kott uploaded patch set 6
CR +1V +104/11/23, 10:03 -
core-ci voted on patch set 6 V +1 04/11/23, 10:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40452
-
Georg Ringer voted on patch set 6 V +1 CR +1 04/12/23, 04:42
-
Markus Klein voted on patch set 6 V +1 CR +1 04/12/23, 06:05
-
Andreas Kienast voted on patch set 6 V +2 CR +2 04/13/23, 07:56
-
Andreas Kienast merged patch set 7 04/13/23, 07:56