Review main Merged

78523[TASK] Drop special styling for popover, tooltips, h1, h2 and h3

Benjamin Kott CR +2 V +2 Normal +62 −166 updated 04/13/23, 07:56

Commit message

There is not need for a special styling here, the components
are fine as is. We are now preferring the defaults over the
custom adjustments.

In rare cases the alignment needed to be adjusted for the
not missing default margin top of h2 and h3. These are
now hotfixed with manual adjustments until we managed
to solve the root problem with custom grids not providing
enough space for the next element.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Georg Ringer +1
    • Markus Klein +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Georg Ringer +1
    • Markus Klein +1
    • core-ci +1 CI

Issues 1

Files 33

Show 13 more files

Review log 2228

Show 23 earlier messages
  1. Benjamin Kott uploaded patch set 1 04/06/23, 13:31

  2. core-ci voted on patch set 1 V +1 04/06/23, 13:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40293

  3. Andreas Kienast voted on patch set 1 CR +1 04/06/23, 14:20

  1. Jasmina Ließmann commented on patch set 1 04/06/23, 17:40

    Fine for me except: 1 / Is there a similar replacement for 'text-monospace' that can be used for the page TSconfig code inside the module? If not then I would be in favor of keeping the classes in the "typo3/sysext/backend/Resources/Private/Templates/PageTsConfig/Active.html" file. 2 / The introductory text p.lead now sticks too much to the following content. This could be solved by adding the "mb-3" class (on all occurrences), but I would be in favor of keeping the custom style for this paragraph.
  2. Benjamin Kott uploaded patch set 2 CR +1 V +1 04/07/23, 08:22

  3. Benjamin Kott commented on patch set 1 04/07/23, 08:26

    Reply

    Remarks: 1. You are right, this is a rebase error - the text-monospace classes are removed in a dedicated patch without replacement see https://review.typo3.org/c/Packages/TYPO3.CMS/+/78485 2. You are right about the lead, but its less about the spacing lead consumes but more about the spacing h1 generated. I also removed almost all .lead ocurrances and replaced them with normal paragraphs or an h2 where it was misused. If we want to group and make space between elements we need to introduce a header-section or something that makes up the space explitilty but it is bad practice to have random spacings for the default elements.
  4. Benjamin Kott commented on patch set 2 04/07/23, 08:26

    Reply

    Ack
  5. core-ci voted on patch set 2 V +1 04/07/23, 08:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40326

  6. Jasmina Ließmann commented on patch set 2 V -1 CR -1 04/07/23, 11:28

    Reply

    Thanks for restoring the text-monospace class! :) I disagree with removing the .lead class in the introductory text and making it a normal paragraph. The distance between the introductory text and the following elements is therefore too small. Likewise, the text can no longer be distinguished from the labels of possible subsequent form fields. The larger font also provided a good introduction to the respective module. Please see screenshots of several examples in the forge ticket. Maybe we can develop an alternative solution for headers in a separate patch. Until then, I'm in favor of keeping the styles of the class and using them in HTML and against removing them.
  7. Jasmina Ließmann commented on patch set 2 V 0 CR 0 04/07/23, 12:12

    Reply

    As just discussed/written privately: I'm removing my -1 for this patch and preparing a separate patch with a new header component (markup/styling) to render the intro section, once this patch was merged.
  8. Benjamin Kott uploaded patch set 3 V +1 04/07/23, 12:15

  9. core-ci voted on patch set 3 V +1 04/07/23, 12:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40333

  10. Benjamin Kott uploaded patch set 4 V +1 04/07/23, 14:00

  11. core-ci voted on patch set 4 V +1 04/07/23, 14:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40344

  12. Markus Klein commented on patch set 4 04/07/23, 20:42

    Index.html:11

    not sure if a description really qualifies as a h2 maybe going with p.h2 would be better?
  13. Markus Klein commented on patch set 4 04/07/23, 20:44

    Report.html:17

    that's used in linkvalidator.ts, or am I missing something?
  14. Benjamin Kott commented on patch set 4 04/08/23, 13:17

    Index.html:11 Reply

    i would agree, when the contents would not be "General statistics"

    Report.html:17 Reply

    you may are right, did not find any usages will check again!
  15. Benjamin Kott uploaded patch set 5 V +1 04/08/23, 13:19

  16. Benjamin Kott commented on patch set 5 04/08/23, 13:20

    Report.html:17 Reply

    added it again, it is still used
  17. Markus Klein commented on patch set 5 04/08/23, 13:47

    Index.html:11 Reply

    oh dear. alright then
  18. Markus Klein voted on patch set 5 V +1 CR +1 04/08/23, 13:47

  19. core-ci voted on patch set 5 V +1 04/08/23, 13:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40372

  20. Benjamin Kott uploaded patch set 6 CR +1 V +1 04/11/23, 10:03

  21. core-ci voted on patch set 6 V +1 04/11/23, 10:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40452

  22. Georg Ringer voted on patch set 6 V +1 CR +1 04/12/23, 04:42

  23. Markus Klein voted on patch set 6 V +1 CR +1 04/12/23, 06:05

  24. Andreas Kienast voted on patch set 6 V +2 CR +2 04/13/23, 07:56

  25. Andreas Kienast merged patch set 7 04/13/23, 07:56