Review main Merged

78525[BUGFIX] Delete flexform relations when deleting record

Justus Moroni CR +2 V +2 Normal +73 −43 updated 05/20/25, 11:29

Commit message

The tests from #106562 show: When deleting a record with
flexform, relations attached to type=flex fields are not
deleted.

The change implements this.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 4

Files 2

Review log 2637

Show 812 earlier messages
  1. Justus Moroni uploaded patch set 1 04/06/23, 14:49

  2. Justus Moroni uploaded patch set 2 04/06/23, 15:03

  3. core-ci voted on patch set 1 V -1 04/06/23, 15:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40300

  4. Justus Moroni uploaded patch set 3 04/06/23, 15:16

  5. core-ci voted on patch set 2 V -1 04/06/23, 15:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40302

  6. core-ci voted on patch set 3 V -1 04/06/23, 16:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40304

  7. Benni Mack updated the commit message in patch set 4 V -1 05/03/23, 09:55

  8. Benni Mack updated the commit message in patch set 5 10/18/24, 14:07

  9. Benni Mack commented on patch set 5 01/08/25, 15:58

    Hey, any progress on this one? I think we could use some datahandler tests for this
  10. Christian Kuhn uploaded patch set 6 01/30/25, 21:08

  11. core-ci voted on patch set 6 V -1 01/30/25, 21:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73214

  12. Christian Kuhn uploaded patch set 7 V -1 01/30/25, 22:06

  1. core-ci voted on patch set 7 V -1 01/30/25, 22:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73216

  2. Christian Kuhn uploaded patch set 8 V -1 01/30/25, 22:20

  3. core-ci voted on patch set 8 V +1 01/30/25, 22:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73217

  4. Christian Kuhn uploaded patch set 9 V +1 01/30/25, 23:39

  5. Christian Kuhn commented on patch set 9 01/30/25, 23:41

    disabled the 'move' solution for now established a basic test setup with a flex field having a file relation -> on discard, the sys_file_reference delete placeholder is not removed
  6. core-ci voted on patch set 9 V +1 01/30/25, 23:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73218

  7. Christian Kuhn commented on patch set 9 03/19/25, 09:40

    i'll take care of the move part with https://review.typo3.org/c/Packages/TYPO3.CMS/+/88648
  8. Benni Mack commented on patch set 9 04/12/25, 21:03

    Hi Justus and Lolli. localize (not covered here) was fixed in the meanwhile (last few days) delete: - tests added here: https://review.typo3.org/c/Packages/TYPO3.CMS/+/89081 - fix extracted here: https://review.typo3.org/c/Packages/TYPO3.CMS/+/89094 move + copy is not handled yet by me. I also found another interesting case: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61085 which is this one https://forge.typo3.org/issues/82221 which we should also evaluate
  9. Christian Kuhn uploaded patch set 10 V +1 05/16/25, 11:01

  10. core-ci voted on patch set 10 V -1 05/16/25, 11:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79045

  11. Christian Kuhn uploaded patch set 11 V -1 05/16/25, 11:43

  12. Christian Kuhn commented on patch set 11 05/16/25, 11:44

  13. core-ci voted on patch set 11 V +1 05/16/25, 11:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79056

  14. Christian Kuhn uploaded patch set 12 V +1 05/16/25, 13:39

  15. Christian Kuhn voted on patch set 12 CR +1 V +1 05/16/25, 13:40

  16. Christian Kuhn commented on patch set 12 05/16/25, 13:40

    note the v13 backport will be delayed for a while.
  17. Benni Mack commented on patch set 12 05/16/25, 13:43

    DataHandler.php:5699

    mb_strlen > 0 better than '$value !== 0' ?

    DataHandler.php:5714

    $dataStructureArray['sheets'] ?? []
  18. core-ci voted on patch set 12 V +1 05/16/25, 13:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79068

  19. Christian Kuhn uploaded patch set 13 CR +1 V +1 05/16/25, 14:36

  20. Christian Kuhn commented on patch set 12 CR +1 V +1 05/16/25, 14:36

    DataHandler.php:5699 Reply

    Done

    DataHandler.php:5714 Reply

    Done
  21. core-ci voted on patch set 13 V +1 05/16/25, 14:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79074

  22. Stefan Bürk voted on patch set 13 CR +1 V +1 05/16/25, 14:55

  23. Christian Kuhn voted on patch set 13 CR +2 V +2 05/20/25, 11:09

  24. Benni Mack voted on patch set 13 CR +1 V +1 05/20/25, 11:28

  25. Christian Kuhn merged patch set 14 05/20/25, 11:29