Review main Abandoned

78526[BUGFIX] Allow placeholders in email link handler

Roman Büchler CR 0 V 0 Easy +27 −4 updated 05/31/23, 11:25

Commit message

mailto:###user###@###domain###?subject=test are
now possible.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 810

  1. Roman Büchler uploaded patch set 1 04/06/23, 14:58

  2. core-ci voted on patch set 1 V +1 04/06/23, 15:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40301

  3. Justus Moroni uploaded patch set 2 V +1 04/06/23, 15:09

  4. core-ci voted on patch set 2 V +1 04/06/23, 15:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40303

  5. Oliver Klee commented on patch set 2 V +1 04/06/23, 15:30

    I like changes with tests!
  6. Stefan Bürk commented on patch set 2 CR -1 04/06/23, 17:01

    I don't like this change. Using this kind of placeholders here are not protocol conform for a "mailto" link. * invalid mailto syntax * not cleare where/and which replaces the placeholder * may not be correct in all context (cli ? be ? ) * why should it be placeholder here ? Would suggest you use then a "placeholder@example.org" email and replaces it later than, but generic mailto pasing is not broken. Okay, you fixes it on one place, but that does not mean that all consumers may do this. Therefore, this is not a "simple" bugfix, as I would not consider this as a bug. If at all, it should be more a FEATURE (v13) with proper rest file and awareness raise and EXTENDED work on it on all places and considering the whole load. But I would not add such weired syntax to it. On import, fix/replace these constants directly wo write correct syntax into it (or fix it on the export). I would not merge this as bugfix, as this is most likly a "regression" for some instances.
  7. Christian Kuhn commented on patch set 2 CR -1 04/06/23, 18:20

    You refer in the issue to "typoscript constant place holders" ... do you mean the "constants" top level array in frontend setup TypoScript, that can be used to substitute values in parseFunc if constants = 1 is set? If so, this has been deprecated in v12 with https://forge.typo3.org/issues/99040, which probably voids the patch?
  8. Benni Mack updated the commit message in patch set 3 CR -1 V +1 05/03/23, 09:43

  9. Roman Büchler commented on patch set 3 05/31/23, 11:17

    Reply

    Thank you very much for this feedback. Using a placeholder email address seems to be a good solution.
  10. Roman Büchler abandoned the change 05/31/23, 11:25