Review main Merged

78531[TASK] Avoid extending other test classes

Christian Kuhn CR +2 V +2 Easy +39 −2 updated 04/07/23, 11:25

Commit message

Test classes (*.Test.php) should not extend
each other. If really needed, they can rely
on abstracts (Abstract*TestCase.php) files
for common functionality.

Also, .csv fixture files shouldn't be
cross used between extensions and
functional and functionalDeprecated
directories to avoid dead files.

Avoid this for a deprecated test case.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 56

  1. Christian Kuhn uploaded patch set 1 04/06/23, 19:48

  2. core-ci voted on patch set 1 V +1 04/06/23, 19:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40318

  3. Oliver Klee voted on patch set 1 V +1 04/06/23, 20:03

  4. Oliver Klee voted on patch set 1 CR +1 04/06/23, 20:03

  5. Christian Kuhn commented on patch set 1 V +2 CR +2 04/07/23, 11:25

    obvious ... will merge.
  6. Christian Kuhn merged patch set 2 04/07/23, 11:25