Review main Merged

78533[TASK] Drop usage of text(-*)-right and .text(-*)-left

Benjamin Kott CR +2 V +2 Normal +152 −87 updated 04/11/23, 09:47

Commit message

To better support RTL languages we start dropping the
legacy bootstrap directional class names for text alignment
and start using the logical property names instead.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Markus Klein +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Markus Klein +1
    • core-ci +1 CI

Issues 1

Files 20

Review log 1318

  1. Benjamin Kott uploaded patch set 1 04/07/23, 09:26

  2. core-ci voted on patch set 1 V +1 04/07/23, 09:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40327

  3. Benjamin Kott uploaded patch set 2 V +1 04/07/23, 14:01

  4. core-ci voted on patch set 2 V +1 04/07/23, 14:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40345

  5. Markus Klein commented on patch set 2 04/07/23, 20:49

    Default.yaml:58

    what happens to existing text, if we change this? I suppose the alignment is not correctly indicated by the editor anymore, right?
  6. Benjamin Kott commented on patch set 2 04/08/23, 06:14

    Default.yaml:58 Reply

    text that exists, will keep it´s position but the not indicated by the buttons.
  7. Markus Klein commented on patch set 2 04/08/23, 13:43

    Default.yaml:58 Reply

    should we at least communicate this with an important.rst?
  8. Benjamin Kott uploaded patch set 3 V +1 04/09/23, 08:56

  9. Benjamin Kott commented on patch set 3 04/09/23, 08:57

    Default.yaml:58 Reply

    ive added an rst please check for completeness
  10. core-ci voted on patch set 3 V +1 04/09/23, 09:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40396

  11. Markus Klein commented on patch set 4 V +1 04/10/23, 20:06

    Published edit on patch set 3.
  12. Markus Klein commented on patch set 5 04/10/23, 20:09

    Published edit on patch set 4.
  13. Markus Klein commented on patch set 5 V +1 CR +1 04/10/23, 20:09

    Default.yaml:58 Reply

    Done
  14. core-ci voted on patch set 5 V +1 04/10/23, 20:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40421

  15. core-ci voted on patch set 4 V +1 04/10/23, 20:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40420

  16. Andreas Kienast voted on patch set 5 CR +1 04/11/23, 06:13

  17. Benni Mack voted on patch set 5 V +2 CR +2 04/11/23, 09:47

  18. Benni Mack merged patch set 6 04/11/23, 09:47