Review main Merged

78538[TASK] Adjust CSS compiling to keep breaks in results

Benjamin Kott CR +2 V +2 Nightmare +4739 −10 updated 04/07/23, 13:55

Commit message

Today we are dropping the removal of breaks in compiled CSS.

This will hopefully make the need for rebasing of CSS patches less
likely and improve the readability of compiled CSS massively
and better shows the impact of changes.

With the current state of CSS the overall increase of file size
will be marginally and not noticeable at all.

This is a well thought through tradeoff, that feels more
than acceptable. The differences in size are listed below:

adminpanel.css
- without breaks: 40.3 kB
- with breaks: 40.6 kB

webfont.css
- without breaks: 3.09 kB
- with breaks: 3.1 kB

backend.css:
- without breaks: 380 kb
- with breaks: 385 kB

dashboard.css:
- without breaks: 6.97 kB
- with breaks: 7.06 kB

dashboard/modal.css
- without breaks: 1.21 kB
- with breaks: 1.22 kB

form.css
- without breaks: 28 kB
- with breaks: 28.3 kB

workspaces.css
- without breaks: 3.05 kB
- with breaks: 3.09 kB

Note: Those files are transferred using compression usually.
That means the additional white spaces will be almost eliminated
by brotli and colleagues.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oliver Klee +1
    • Markus Klein +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Markus Klein +1

Issues 1

Files 8

Review log 1116

  1. Benjamin Kott uploaded patch set 1 04/07/23, 13:24

  2. core-ci voted on patch set 1 V +1 04/07/23, 13:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40336

  3. Benjamin Kott uploaded patch set 2 V +1 04/07/23, 13:32

  4. Oliver Klee voted on patch set 2 CR +1 04/07/23, 13:38

  5. Markus Klein updated the commit message in patch set 3 CR +1 04/07/23, 13:39

  6. Markus Klein updated the commit message in patch set 4 04/07/23, 13:40

  7. core-ci voted on patch set 2 V +1 04/07/23, 13:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40337

  8. Markus Klein voted on patch set 4 V +1 CR +1 04/07/23, 13:41

  9. Benjamin Kott uploaded patch set 5 CR +1 V +1 04/07/23, 13:43

  10. Oliver Klee voted on patch set 5 CR +1 04/07/23, 13:47

  11. Markus Klein voted on patch set 5 V +1 CR +1 04/07/23, 13:51

  12. core-ci voted on patch set 3 V +1 04/07/23, 13:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40339

  13. core-ci voted on patch set 4 V +1 04/07/23, 13:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40340

  14. Andreas Kienast voted on patch set 5 V +2 CR +2 04/07/23, 13:54

  15. Andreas Kienast merged patch set 6 04/07/23, 13:54

  16. core-ci voted on patch set 5 V +1 04/07/23, 13:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40341