78545[TASK] Improve beuser templates
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Jasmina Ließmann +1
-
Verified V +2 Done
- Christian Kuhn +2
- Jasmina Ließmann +1
- core-ci +1 CI
Issues 1
Files 40
- Build/Sources/Sass/component/_table.scss+2 −2
- typo3/sysext/backend/Resources/Public/Css/backend.css+2 −2
- typo3/sysext/beuser/Classes/Controller/BackendUserController.php+4 −4
- typo3/sysext/beuser/Resources/Private/Language/locallang.xlf+30 −13
- typo3/sysext/beuser/Resources/Private/Layouts/Permission.html+7 −0
- typo3/sysext/beuser/Resources/Private/Partials/BackendUser/Filter.htmlrenamed+7 −0
- typo3/sysext/beuser/Resources/Private/Partials/BackendUser/IndexListRow.htmldeleted+0 −129
- typo3/sysext/beuser/Resources/Private/Partials/BackendUser/OnlineListRow.htmldeleted+0 −56
- typo3/sysext/beuser/Resources/Private/Partials/BackendUser/PaginatedList.html+139 −13
- typo3/sysext/beuser/Resources/Private/Partials/BackendUserGroup/Filter.htmlrenamed+7 −0
- typo3/sysext/beuser/Resources/Private/Partials/BackendUserGroup/IndexListRow.htmldeleted+0 −86
- typo3/sysext/beuser/Resources/Private/Partials/BackendUserGroup/PaginatedList.html+112 −17
- typo3/sysext/beuser/Resources/Private/Partials/Compare/Information.html+208 −198
- typo3/sysext/beuser/Resources/Private/Partials/Filemount/IndexListRow.htmldeleted+0 −74
- typo3/sysext/beuser/Resources/Private/Partials/Filemount/NoFilemounts.htmldeleted+0 −30
- typo3/sysext/beuser/Resources/Private/Partials/Filemount/PaginatedList.html+87 −5
- typo3/sysext/beuser/Resources/Private/Partials/Filemount/TotalFilemounts.htmldeleted+0 −15
- typo3/sysext/beuser/Resources/Private/Partials/SimplePagination.html+8 −0
- typo3/sysext/beuser/Resources/Private/Templates/BackendUser/Compare.html+40 −24
- typo3/sysext/beuser/Resources/Private/Templates/BackendUser/Filemounts.htmldeleted+0 −17
Show 20 more files
- typo3/sysext/beuser/Resources/Private/Templates/BackendUser/Groups.htmldeleted+0 −60
- typo3/sysext/beuser/Resources/Private/Templates/BackendUser/Index.htmldeleted+0 −74
- typo3/sysext/beuser/Resources/Private/Templates/BackendUser/List.htmlnew+77 −0
- typo3/sysext/beuser/Resources/Private/Templates/BackendUser/Online.html+65 −6
- typo3/sysext/beuser/Resources/Private/Templates/BackendUser/Show.html+75 −74
- typo3/sysext/beuser/Resources/Private/Templates/BackendUserGroup/Compare.htmlrenamed+21 −12
- typo3/sysext/beuser/Resources/Private/Templates/BackendUserGroup/List.html3new+66 −0
- typo3/sysext/beuser/Resources/Private/Templates/Filemount/List.htmlnew+37 −0
- typo3/sysext/beuser/Resources/Private/Templates/Permission/ChangeGroup.html+2 −0
- typo3/sysext/beuser/Resources/Private/Templates/Permission/ChangeGroupSelector.html+19 −15
- typo3/sysext/beuser/Resources/Private/Templates/Permission/ChangeOwner.html+2 −0
- typo3/sysext/beuser/Resources/Private/Templates/Permission/ChangeOwnerSelector.html+15 −13
- typo3/sysext/beuser/Resources/Private/Templates/Permission/ChangePermission.html+4 −2
- typo3/sysext/beuser/Resources/Private/Templates/Permission/Edit.html+4 −5
- typo3/sysext/beuser/Resources/Private/Templates/Permission/Index.html+10 −11
- typo3/sysext/beuser/Resources/Private/Templates/Permission/ToggleEditLock.html+3 −1
- typo3/sysext/core/Tests/Acceptance/Application/BackendUser/CompareUserCest.php+10 −10
- typo3/sysext/core/Tests/Acceptance/Application/BackendUser/ListGroupCest.php+3 −3
- typo3/sysext/core/Tests/Acceptance/Application/BackendUser/ListUserCest.php+3 −3
- typo3/sysext/core/Tests/Acceptance/Application/Impexp/UsersCest.php+2 −2
Review log 3244
Show 1219 earlier messages
-
Benjamin Kott uploaded patch set 1 04/08/23, 13:11
-
Benjamin Kott updated the commit message in patch set 2 04/08/23, 13:12
-
Benjamin Kott updated the commit message in patch set 3 04/08/23, 13:14
-
Benjamin Kott updated the commit message in patch set 4 04/08/23, 13:20
-
core-ci voted on patch set 1 V -1 04/08/23, 13:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40369
-
core-ci voted on patch set 2 V -1 04/08/23, 13:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40370
-
core-ci voted on patch set 3 V -1 04/08/23, 13:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40371
-
core-ci voted on patch set 4 V -1 04/08/23, 13:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40373
-
Benjamin Kott uploaded patch set 5
V -104/08/23, 13:58 -
core-ci voted on patch set 5 V -1 04/08/23, 14:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40375
-
Benjamin Kott uploaded patch set 6
V -104/08/23, 14:31 -
core-ci voted on patch set 6 V -1 04/08/23, 15:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40378
-
Benjamin Kott uploaded patch set 7
V -104/09/23, 08:37 -
core-ci voted on patch set 7 V +1 04/09/23, 08:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40394
-
Georg Ringer commented on patch set 7 04/12/23, 04:48
should we really remove the html tag? looks wrong to me a bit -
Andreas Kienast commented on patch set 7 04/12/23, 06:07
Reply
It's already "missing" in other partials, so at least it's streamlined now. -
Markus Klein commented on patch set 7 04/12/23, 12:44
Reply
Please keep the HTML tags. any editor with xml-validation (like phpstorm) goes red, deep red, on all templates otherwise. -
Benjamin Kott uploaded patch set 8
V +104/12/23, 16:49 -
Benjamin Kott commented on patch set 8 04/12/23, 16:57
Reply
As mentioned, the usage is random and we are actually talking about document fragements and not documents. The HTML tag indicates the root of a document, partials etc. are not even complete valid nested HTML. I´ve added the namespace imports again and removed them from the global scope, because lolli mentioned this in another patch. This seems to be an IDE configuration issue to me, and i prefer to not bloat the templates with unessesary markup that gets parsed out anyways.
-
core-ci voted on patch set 8 V +1 04/12/23, 16:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40523
-
Christian Kuhn voted on patch set 8 CR -1 04/12/23, 17:25
-
Christian Kuhn commented on patch set 8 04/12/23, 17:29
please keep (or add if missing) the <html tag in all templates, including the used xmlns namespaces: this is valid html, it helps IDE plugins, and auto-completion of VH arguments. please avoid using the {namespace} syntax. -
Jasmina Ließmann uploaded patch set 9
CR -1V +104/12/23, 20:50 -
Jasmina Ließmann uploaded patch set 10 04/12/23, 20:57
-
core-ci voted on patch set 9 V +1 04/12/23, 21:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40529
-
core-ci voted on patch set 10 V +1 04/12/23, 21:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40530
-
Jasmina Ließmann commented on patch set 10 V -1 04/12/23, 21:32
List.html:43When I select multiple backend user groups and click on the button 'Compare backend usergroups', I get an error in file '\typo3\sysext\beuser\Classes\Service\UserInformationService.php' at line 235. -
Jasmina Ließmann commented on patch set 10 04/12/23, 21:32
I love the new style of comparison list! Thanks for taking care of it! Some thoughts about the backend user details: - The contents in the columns below the table still look a little wild. How about if all areas are presented in two columns instead of the three columns in the first row? - If there is no configuration in a section, only the headings are displayed (sometimes several below each other, e.g. for admin accounts or backend users who obtain all settings from their groups). Perhaps we can add a note for each section where there is no configuration? -
Jasmina Ließmann uploaded patch set 11
V +104/12/23, 21:34 -
Jasmina Ließmann commented on patch set 11 CR -1 04/12/23, 21:37
Reply
I agree with the others to keep the html tag. -
core-ci voted on patch set 11 V +1 04/12/23, 21:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40534
-
Benjamin Kott commented on patch set 11 04/13/23, 06:02
Reply
I only corrected styles in this area, it was like this when I touched it. I am aware of extra margins on the bottom - not the scope of this patch to find a solution to this. This needs another round of dedicated styling of contents nested in tables. -
Benjamin Kott commented on patch set 11 04/13/23, 06:03
Reply
Problem here is that the partials are used in table and detail view. -
Benjamin Kott uploaded patch set 12
CR -1V +104/13/23, 07:04 -
Benjamin Kott commented on patch set 12 04/13/23, 07:06
Reply
Done -
Benjamin Kott commented on patch set 12 04/13/23, 07:06
Reply
Ack -
Benjamin Kott commented on patch set 12 04/13/23, 07:08
List.html:43Replyi cannot reproduce the error -
core-ci voted on patch set 12 V +1 04/13/23, 07:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40546
-
Benjamin Kott commented on patch set 12 04/13/23, 09:17
List.html:43Reply -
Andreas Kienast commented on patch set 12 04/13/23, 12:53
Minor issue: when comparing two backend users, the right hand TSconfig tree has no "outer" line. This is fixed when zooming in to 110% or 150%. -
Andreas Kienast commented on patch set 12 04/13/23, 12:58
Reply
This is no issue introduced by this patch. The affected TSconfig tree has only one direct <li> ancestor of the <ul> and therefore the tree behaves correctly as defined per CSS. -
Jasmina Ließmann voted on patch set 12 V +1 CR +1 04/13/23, 12:58
-
Christian Kuhn voted on patch set 12 V +2 CR +2 04/13/23, 13:00
-
Christian Kuhn merged patch set 13 04/13/23, 13:00