Review main Merged

78557[BUGFIX] Render only one toggle per node in trees

Andreas Kienast CR +2 V +2 Normal +70 −45 updated 07/06/23, 17:26

Commit message

In non-SVG trees, there are currently two icons representing the node's
expansion state rendered that get toggled via CSS rules based on
hard-coded aria attributes and icon identifiers, which is a bad
practice.

To solve this, a new web component `typo3-backend-tree-node-toggle` is
added whose only responsibility is to render the correct icon based on
its `aria-expanded` attribute

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Frank Nägler +1
  • Verified V +2 Done
    • Benni Mack +2
    • Frank Nägler +1
    • core-ci +1 CI

Issues 1

Files 12

Review log 1217

  1. Andreas Kienast uploaded patch set 1 04/11/23, 09:29

  2. core-ci voted on patch set 1 V -1 04/11/23, 09:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40447

  3. Andreas Kienast uploaded patch set 2 V -1 04/11/23, 10:05

  4. Andreas Kienast uploaded patch set 3 04/11/23, 10:06

  5. Andreas Kienast uploaded patch set 4 04/11/23, 10:15

  6. core-ci voted on patch set 4 V +1 04/11/23, 10:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40456

  7. Andreas Kienast updated the commit message in patch set 5 V +1 04/11/23, 10:28

  8. core-ci voted on patch set 5 V +1 04/11/23, 10:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40457

  9. Benni Mack rebased onto patch set 6 V +1 04/24/23, 14:38

  10. core-ci voted on patch set 6 V +1 04/24/23, 14:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41173

  11. Benni Mack updated the commit message in patch set 7 V +1 05/03/23, 09:47

  12. Oli Bartsch rebased onto patch set 8 07/03/23, 07:53

  13. core-ci voted on patch set 8 V +1 07/03/23, 08:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43202

  14. Benni Mack voted on patch set 8 V +1 CR +1 07/06/23, 12:06

  15. Frank Nägler commented on patch set 8 V +1 CR +1 07/06/23, 17:14

    Looks and works like before ;)
  16. Benni Mack voted on patch set 8 V +2 CR +2 07/06/23, 17:26

  17. Benni Mack merged patch set 9 07/06/23, 17:26