Review main Merged

78594[BUGFIX] Broken returnUrl in db check search

Christian Kuhn CR +2 V +2 Easy +2 −25 updated 04/12/23, 14:51

Commit message

The "DB check" -> "Full search" module allows to show
soft-deleted records. Such result rows have a button
to "undelete" the record, and to undelete and then edit
the record. Both links have a link back to the
module which is broken ("backend-in-backend").

The patch removes the second button entirely: It should
be enough for this seldom used functionality, to first
undelete, re-render the search result, and then edit.

The undelete button return url is fixed with the patch,
even though it is questionable if "undelete" should be
part of this module in the first place. Redefining and
refactoring the module is however a task of further
patches.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Oliver Klee +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 67

  1. Christian Kuhn uploaded patch set 1 04/12/23, 10:04

  2. core-ci voted on patch set 1 V +1 04/12/23, 10:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40491

  3. Benni Mack voted on patch set 1 V +1 CR +1 04/12/23, 11:23

  4. Oliver Klee voted on patch set 1 CR +1 04/12/23, 11:34

  5. Jochen Roth voted on patch set 1 V +1 CR +1 04/12/23, 14:43

  6. Christian Kuhn voted on patch set 1 V +2 CR +2 04/12/23, 14:51

  7. Christian Kuhn merged patch set 2 04/12/23, 14:51