78596[TASK] Cleanup impexp templates
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Christian Kuhn +1
-
Verified V +2 Done
- Benni Mack +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 31
- Build/phpstan/phpstan-baseline.neon+0 −5
- Build/Sources/Sass/component/_indent.scssnew+18 −0
- Build/Sources/Sass/component/_modal.scss+0 −4
- Build/Sources/Sass/component/_panel.scss+0 −4
- Build/Sources/Sass/component/_treelist.scss+3 −3
- Build/Sources/Sass/backend.scss2+1 −0
- typo3/sysext/backend/Resources/Public/Css/backend.css+4 −4
- typo3/sysext/core/Tests/Acceptance/Application/Impexp/ExportCest.php+9 −13
- typo3/sysext/core/Tests/Acceptance/Application/Impexp/ImportCest.php+2 −3
- typo3/sysext/impexp/Classes/ImportExport.php+69 −77
- typo3/sysext/impexp/Resources/Private/Language/locallang.xlf+1 −4
- typo3/sysext/impexp/Resources/Private/Partials/Export/AdvancedOptions.html+75 −59
- typo3/sysext/impexp/Resources/Private/Partials/Export/Configuration.html+172 −162
- typo3/sysext/impexp/Resources/Private/Partials/Export/Save.html+192 −161
- typo3/sysext/impexp/Resources/Private/Partials/Import/Import.html+183 −160
- typo3/sysext/impexp/Resources/Private/Partials/Import/MetaData.html+47 −43
- typo3/sysext/impexp/Resources/Private/Partials/Import/Upload.html+58 −41
- typo3/sysext/impexp/Resources/Private/Partials/Preview.html+51 −50
- typo3/sysext/impexp/Resources/Private/Templates/Export.html+9 −26
- typo3/sysext/impexp/Resources/Private/Templates/Import.html+10 −26
Show 11 more files
- typo3/sysext/impexp/Tests/Functional/Fixtures/ArrayAssertions/RenderPreviewExportPageAndRecords.php+67 −93
- typo3/sysext/impexp/Tests/Functional/Fixtures/ArrayAssertions/RenderPreviewExportPageAndRecordsWithSoftRefs.php+44 −64
- typo3/sysext/impexp/Tests/Functional/Fixtures/ArrayAssertions/RenderPreviewExportRecords.php+18 −22
- typo3/sysext/impexp/Tests/Functional/Fixtures/ArrayAssertions/RenderPreviewExportTable.php+27 −33
- typo3/sysext/impexp/Tests/Functional/Fixtures/ArrayAssertions/RenderPreviewImportPageAndRecords.php+26 −26
- typo3/sysext/impexp/Tests/Functional/Fixtures/ArrayAssertions/RenderPreviewImportPageAndRecordsByUpdate.php+22 −22
- typo3/sysext/impexp/Tests/Functional/Fixtures/ArrayAssertions/RenderPreviewImportPageAndRecordsByUpdateWithDiff.php+65 −65
- typo3/sysext/impexp/Tests/Functional/Fixtures/ArrayAssertions/RenderPreviewImportPageAndRecordsWithDiff.php+56 −56
- typo3/sysext/impexp/Tests/Functional/Fixtures/ArrayAssertions/RenderPreviewImportPageAndRecordsWithSoftRefs.php+18 −18
- typo3/sysext/impexp/Tests/Functional/ExportTest.php+2 −2
- typo3/sysext/impexp/Tests/Functional/ImportTest.php+2 −2
Review log 1824
-
Benjamin Kott uploaded patch set 1 04/12/23, 12:00
-
core-ci voted on patch set 1 V -1 04/12/23, 12:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40504
-
Andreas Kienast commented on patch set 1 04/12/23, 14:26
-
Christian Kuhn commented on patch set 1 CR -1 04/12/23, 14:57
ext_localconf.php:8please avoid global namespace. use imports in needed html templates instead. please do not omit the xmlns definition in templates. -
Benjamin Kott uploaded patch set 2
CR -1V -104/12/23, 15:59 -
Christian Kuhn voted on patch set 2 CR -1 04/12/23, 16:01
-
Benjamin Kott commented on patch set 2 04/12/23, 16:03
ext_localconf.php:8Replyjust leave the comment open, will be resolved later. -
Benjamin Kott uploaded patch set 3
CR -104/12/23, 16:38 -
Benjamin Kott commented on patch set 3 04/12/23, 16:39
backend.scss:61ReplyDoneext_localconf.php:8ReplyDone -
core-ci voted on patch set 2 V -1 04/12/23, 16:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40519
-
core-ci voted on patch set 3 V -1 04/12/23, 16:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40521
-
Christian Kuhn commented on patch set 3 04/12/23, 17:28
ext_localconf.php:8Replynot resolved: please keep (or add if missing) the <html tag in all templates, including the used xmlns namespaces: this is valid html, it helps IDE plugins, and auto-completion of VH arguments. -
Benjamin Kott uploaded patch set 4
V -104/13/23, 06:40 -
Benjamin Kott commented on patch set 4 04/13/23, 06:41
ext_localconf.php:8ReplyAck -
core-ci voted on patch set 4 V -1 04/13/23, 07:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40544
-
Benjamin Kott uploaded patch set 5
V -104/13/23, 08:28 -
core-ci voted on patch set 5 V +1 04/13/23, 08:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40554
-
Christian Kuhn updated the commit message in patch set 6
V +104/13/23, 12:28 -
core-ci voted on patch set 6 V +1 04/13/23, 12:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40565
-
Benni Mack commented on patch set 6 CR +1 04/14/23, 09:56
Had the same remarks as lolli, thanks for resolving them. Looks good now -
Benni Mack voted on patch set 6 V +1 04/14/23, 11:06
-
Christian Kuhn voted on patch set 6 V +1 CR +1 04/14/23, 11:36
-
Benni Mack voted on patch set 6 V +2 CR +2 04/14/23, 11:40
-
Benni Mack merged patch set 7 04/14/23, 11:40
backend.scss:61