Review main Merged

78596[TASK] Cleanup impexp templates

Benjamin Kott CR +2 V +2 Expert +1251 −1248 updated 04/14/23, 11:40

Commit message

- Migrate checkboxes to form-check
- Rebuild indention of rows
- Add icons to buttons
- Add sections to tabs
- Add missing input classes

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 31

Show 11 more files

Review log 1824

  1. Benjamin Kott uploaded patch set 1 04/12/23, 12:00

  2. core-ci voted on patch set 1 V -1 04/12/23, 12:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40504

  3. Andreas Kienast commented on patch set 1 04/12/23, 14:26

    backend.scss:61

    I think "indentation" is the proper term.
  4. Christian Kuhn commented on patch set 1 CR -1 04/12/23, 14:57

    ext_localconf.php:8

    please avoid global namespace. use imports in needed html templates instead. please do not omit the xmlns definition in templates.
  5. Benjamin Kott uploaded patch set 2 CR -1 V -1 04/12/23, 15:59

  6. Christian Kuhn voted on patch set 2 CR -1 04/12/23, 16:01

  7. Benjamin Kott commented on patch set 2 04/12/23, 16:03

    ext_localconf.php:8 Reply

    just leave the comment open, will be resolved later.
  8. Benjamin Kott uploaded patch set 3 CR -1 04/12/23, 16:38

  9. Benjamin Kott commented on patch set 3 04/12/23, 16:39

    backend.scss:61 Reply

    Done

    ext_localconf.php:8 Reply

    Done
  10. core-ci voted on patch set 2 V -1 04/12/23, 16:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40519

  11. core-ci voted on patch set 3 V -1 04/12/23, 16:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40521

  12. Christian Kuhn commented on patch set 3 04/12/23, 17:28

    ext_localconf.php:8 Reply

    not resolved: please keep (or add if missing) the <html tag in all templates, including the used xmlns namespaces: this is valid html, it helps IDE plugins, and auto-completion of VH arguments.
  13. Benjamin Kott uploaded patch set 4 V -1 04/13/23, 06:40

  14. Benjamin Kott commented on patch set 4 04/13/23, 06:41

    ext_localconf.php:8 Reply

    Ack
  15. core-ci voted on patch set 4 V -1 04/13/23, 07:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40544

  16. Benjamin Kott uploaded patch set 5 V -1 04/13/23, 08:28

  17. core-ci voted on patch set 5 V +1 04/13/23, 08:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40554

  18. Christian Kuhn updated the commit message in patch set 6 V +1 04/13/23, 12:28

  19. core-ci voted on patch set 6 V +1 04/13/23, 12:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40565

  20. Benni Mack commented on patch set 6 CR +1 04/14/23, 09:56

    Had the same remarks as lolli, thanks for resolving them. Looks good now
  21. Benni Mack voted on patch set 6 V +1 04/14/23, 11:06

  22. Christian Kuhn voted on patch set 6 V +1 CR +1 04/14/23, 11:36

  23. Benni Mack voted on patch set 6 V +2 CR +2 04/14/23, 11:40

  24. Benni Mack merged patch set 7 04/14/23, 11:40