Review main Merged

78603[BUGFIX] Ensure email links do not throw an exception

Benni Mack CR +2 V +2 Easy +4 −4 updated 04/12/23, 19:27

Commit message

When upgrading a project to TYPO3 v12,
the new email link validator now
checks for other properties than the
email address such as "to" etc.

However, in previous TYPO3 v11 installations,
it was possible to enter a link like " benni@typo3.org"
and it worked, the new link handler now fatals
due a stricter parsing, which is now relaxed,
as the value is now trimmed.

Once editors modify all their links, it would
work, however, that's not in scope for the
LTS, and would require a Upgrade Wizard
which also checks for HTML links. This way,
it is much easier to overcome the problem
by trimming the values.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Benni Mack uploaded patch set 1 04/12/23, 15:54

  2. core-ci voted on patch set 1 V +1 04/12/23, 16:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40517

  3. Christian Kuhn voted on patch set 1 V +1 CR +1 04/12/23, 19:27

  4. Stefan Bürk voted on patch set 1 V +1 CR +1 04/12/23, 19:27

  5. Christian Kuhn voted on patch set 1 V +2 CR +2 04/12/23, 19:27

  6. Christian Kuhn merged patch set 2 04/12/23, 19:27