Review 11.5 Merged

78615[BUGFIX] Pre-define `cropBox` in Image Manipulation

Andreas Kienast CR +2 V +2 Easy +2 −2 updated 04/13/23, 10:45

Commit message

This patch pre-defines `cropBox` with an empty jQuery object to avoid
errors when starting the image cropper. A similar fix was already done
in #99953, that's why the issue doesn't pop up in v12.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oliver Klee +1
    • Anja Leichsenring +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Anja Leichsenring +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 67

  1. Andreas Kienast uploaded patch set 1 04/13/23, 09:59

  2. core-ci voted on patch set 1 V +1 04/13/23, 10:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40558

  3. Anja Leichsenring commented on patch set 1 V +1 CR +1 04/13/23, 10:10

    thank you very much, you saved my acceptance tests 😊
  4. Oliver Klee voted on patch set 1 CR +1 04/13/23, 10:32

  5. Christian Kuhn voted on patch set 1 V +1 CR +1 04/13/23, 10:45

  6. Andreas Kienast voted on patch set 1 V +2 CR +2 04/13/23, 10:45

  7. Andreas Kienast merged patch set 2 04/13/23, 10:45