Review main Merged

78624[BUGFIX] Allow digit only strings in EmailFinisher

Oli Bartsch CR +2 V +2 Easy +3 −4 updated 04/14/23, 07:40

Commit message

Since it's valid to use a digit-only subject or title, those
options are now properly cast to a string, preventing
TypeError exceptions when passing them to type-hinted
functions. This happened due to PHP converting digit-only
strings to integers.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Oliver Klee +1
    • Jochen Roth +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 79

  1. Oli Bartsch uploaded patch set 1 04/13/23, 17:26

  2. core-ci voted on patch set 1 V +1 04/13/23, 17:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40578

  3. Oliver Klee updated the commit message in patch set 2 V +1 04/13/23, 18:14

  4. Oliver Klee voted on patch set 2 CR +1 04/13/23, 18:14

  5. core-ci voted on patch set 2 V +1 04/13/23, 18:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40579

  6. Christian Kuhn voted on patch set 2 V +1 CR +1 04/14/23, 05:33

  7. Jochen Roth voted on patch set 2 V +1 CR +1 04/14/23, 07:38

  8. Oli Bartsch voted on patch set 2 V +2 CR +2 04/14/23, 07:40

  9. Oli Bartsch merged patch set 3 04/14/23, 07:40