Review 11.5 Merged

78628[BUGFIX] Allow digit only strings in EmailFinisher

Oli Bartsch CR +2 V +2 Easy +3 −4 updated 04/14/23, 08:09

Commit message

Since it's valid to use a digit-only subject or title, those
options are now properly cast to a string, preventing
TypeError exceptions when passing them to type-hinted
functions. This happened due to PHP converting digit-only
strings to integers.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Oli Bartsch uploaded patch set 1 04/14/23, 07:42

  2. core-ci voted on patch set 1 V +1 04/14/23, 07:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40596

  3. Oli Bartsch voted on patch set 1 V +2 CR +2 04/14/23, 08:09

  4. Oli Bartsch merged patch set 2 04/14/23, 08:09