Review main Merged

78632[TASK] Avoid ext:install uri.action VH

Christian Kuhn CR +2 V +2 Normal +66 −109 updated 04/14/23, 12:02

Commit message

The ext:install uri.action ViewHelper is - after
various previous refactorings - only used within
standalone install tool to create the main module
links.

The code can be simplified nowadays, avoiding the
view helper entirely. The patch takes care of this
and simplifies the templates by removing one
partial entirely.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Andreas Kienast +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 912

  1. Christian Kuhn uploaded patch set 1 04/14/23, 11:31

  2. Benni Mack commented on patch set 1 04/14/23, 11:39

    LayoutController.php:50

    double space
  3. core-ci voted on patch set 1 V +1 04/14/23, 11:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40608

  4. Christian Kuhn commented on patch set 1 04/14/23, 11:41

    LayoutController.php:50 Reply

    Done
  5. Christian Kuhn uploaded patch set 2 V +1 04/14/23, 11:45

  6. Christian Kuhn updated the commit message in patch set 3 04/14/23, 11:46

  7. Benni Mack voted on patch set 3 V +1 CR +1 04/14/23, 11:50

  8. core-ci voted on patch set 2 V +1 04/14/23, 11:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40610

  9. core-ci voted on patch set 3 V +1 04/14/23, 11:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40611

  10. Andreas Kienast voted on patch set 3 V +1 CR +1 04/14/23, 12:02

  11. Christian Kuhn voted on patch set 3 V +2 CR +2 04/14/23, 12:02

  12. Christian Kuhn merged patch set 4 04/14/23, 12:02