Review main Merged

78638[TASK] Avoid GU::_GET() in ServerRequestFactory

Christian Kuhn CR +2 V +2 Easy +2 −4 updated 04/14/23, 13:07

Commit message

ServerRequestFactory is essentially the only
place with a legit access to $_GET super global.
Avoid using GeneralUtility::_GET() here.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Andreas Kienast +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 67

  1. Christian Kuhn uploaded patch set 1 04/14/23, 12:39

  2. core-ci voted on patch set 1 V +1 04/14/23, 12:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40618

  3. Benni Mack voted on patch set 1 V +1 CR +1 04/14/23, 13:05

  4. Andreas Kienast voted on patch set 1 V +1 CR +1 04/14/23, 13:07

  5. Anja Leichsenring voted on patch set 1 V +1 CR +1 04/14/23, 13:07

  6. Christian Kuhn voted on patch set 1 V +2 CR +2 04/14/23, 13:07

  7. Christian Kuhn merged patch set 2 04/14/23, 13:07