Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.

Review main Work in progress Orphaned

78652[WIP][TASK] Introduce PageRenderer resource models

Oliver Hader CR 0 V 0 Hard +514 −153 updated 04/22/23, 11:07

Commit message

Instead of extending `PageRenderer` methods by method params again
and again, instructions are encapsulated in data transfer objects.
For backward compatibility reasons, these objects can still be used
as arrays when reading data - modifying array data is not supported.

* current invocation
  $pageRenderer->addCssFile('file.css', 'stylesheet', 'all', 'my-title');
* potential future invocation
  $styleSheetFile = new StyleSheetFileDto('file.css');
  $styleSheetFile->title = 'my-title';
  $pageRenderer->addCssFile($styleSheetFile);

Adding new aspects and behavior to `StyleSheetFileDto` seems to be
simpler and does not require to adjust all involved methods that are
just transferring the data to the final compressor/renderer.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 4
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/52/78652/4 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/52/78652/4 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V 0

    Imported before Forger kept the single votes, the next import adds them.

Files 14