Review main Merged

78656[BUGFIX] Set 'typoLinkParameter' array index for error handling

Albrecht Köhnlein CR +2 V +2 Easy +20 −0 updated 04/16/23, 19:19

Commit message

Set the array index `$linkDetails['typoLinkParameter']` in
`\TYPO3\CMS\Redirects\Service\RedirectService` to pass it
through. That information is needed for the LinkBuilder.

For example, `DatabaseRecordLinkBuilder` would trigger an
array key access error, in case the linked record cannot
be found and no link can be generated. This array value
is use there for the thrown exception message.

The team play between `LinkService->resolve()` and the
`LinkBuilder->build()` should be reviewed in a dedicated
change. It may be useful, that the resolver directly
adds this information to the result, making the manual
adding at several placed through out the core obsolete.
Comments are added to document this.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1217

  1. Albrecht Köhnlein uploaded patch set 1 04/15/23, 18:38

  2. core-ci voted on patch set 1 V -1 04/15/23, 19:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40695

  3. Albrecht Köhnlein uploaded patch set 2 V -1 04/15/23, 19:56

  4. core-ci voted on patch set 2 V +1 04/15/23, 20:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40704

  5. Anja Leichsenring voted on patch set 2 V +1 CR +1 04/16/23, 14:33

  6. Stefan Bürk commented on patch set 2 CR -1 04/16/23, 14:57

    On it ..
  7. Stefan Bürk uploaded patch set 3 CR +1 V +1 04/16/23, 16:57

  8. core-ci voted on patch set 3 V +1 04/16/23, 17:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40756

  9. Stefan Bürk updated the commit message in patch set 4 V +1 04/16/23, 17:24

  10. core-ci voted on patch set 4 V +1 04/16/23, 17:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40759

  11. Albrecht Köhnlein updated the commit message in patch set 5 V +1 04/16/23, 17:57

  12. core-ci voted on patch set 5 V +1 04/16/23, 18:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40760

  13. Stefan Bürk commented on patch set 5 V +1 CR +1 04/16/23, 18:36

    Should this not be proper
  14. Stefan Bürk commented on patch set 5 04/16/23, 18:36

    Reply

    ^^ Sry, comment above was left over and unfinished - ignore it ;)
  15. Anja Leichsenring voted on patch set 5 V +1 CR +1 04/16/23, 18:39

  16. Stefan Bürk voted on patch set 5 V +2 CR +2 04/16/23, 19:19

  17. Stefan Bürk merged patch set 6 04/16/23, 19:19