Review main Merged

78658[TASK] Deprecate PageRenderer::$inlineJavascriptWrap and $inlineCssWrap

Oliver Hader CR +2 V +2 Normal +88 −25 updated 04/20/23, 10:27

Commit message

The protected properties `$inlineJavascriptWrap` and `$inlineCssWrap`
of the class `\TYPO3\CMS\Core\Page\PageRenderer` have been deprecated.

The new methods `wrapInlineScript()` and `wrapInlineStyle()` have to
be used instead (which also provide special handling for XHTML or
non-HTML5 content rendering).

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Christian Kuhn +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Christian Kuhn +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1622

  1. Oliver Hader uploaded patch set 1 04/15/23, 20:30

  2. core-ci voted on patch set 1 V -1 04/15/23, 20:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40708

  3. Oliver Hader uploaded patch set 2 V -1 04/15/23, 20:45

  4. core-ci voted on patch set 2 V +1 04/15/23, 20:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40711

  5. Oliver Hader commented on patch set 3 V +1 04/15/23, 21:08

    Published edit on patch set 2.
  6. core-ci voted on patch set 3 V +1 04/15/23, 21:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40713

  7. Oliver Hader commented on patch set 4 V +1 04/16/23, 06:43

    Published edit on patch set 3.
  8. core-ci voted on patch set 4 V +1 04/16/23, 06:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40727

  9. Oliver Klee commented on patch set 4 04/17/23, 20:26

    Would it be possible to scan for this using the extension scanner?
  10. Oliver Hader commented on patch set 4 04/18/23, 07:49

    Reply

    It looks like `PropertyPublicMatcher` would be capable of doing this...
  11. Christian Kuhn commented on patch set 4 04/18/23, 08:19

    Reply

    PropertyPublicMatcher is for public properties only. I don't think we can scan for this. Realistically, you can't extend PageRenderer much, it "should" be final anyways. And it's a singleton. So changing it core-wide is possible via xclass if at all. And that is not a b/w compat target. We should add an @todo to the class, to remember declaring it final in v13.
  12. Oliver Hader uploaded patch set 5 V +1 04/19/23, 12:05

  13. Oliver Hader commented on patch set 4 04/19/23, 12:06

    Reply

    Ack. Making this class final would solve a bunch of possible side-effects...
  14. core-ci voted on patch set 5 V +1 04/19/23, 12:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40896

  15. Christian Kuhn voted on patch set 5 V +1 CR +1 04/19/23, 13:17

  16. Oliver Hader uploaded patch set 6 04/19/23, 14:02

    Copied Votes: * Code-Review+1 (copy condition: "changekind:NO_CHANGE OR is:MIN") * Verified+1 (copy condition: "changekind:NO_CHANGE")
  17. core-ci voted on patch set 6 V +1 04/19/23, 14:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40900

  18. Christian Kuhn voted on patch set 6 V +2 CR +2 04/20/23, 10:06

  19. Christian Kuhn voted on patch set 6 V +1 CR +1 04/20/23, 10:06

  20. Andreas Kienast voted on patch set 6 V +1 CR +1 04/20/23, 10:25

  21. Oliver Hader voted on patch set 6 V +2 CR +2 04/20/23, 10:27

  22. Oliver Hader merged patch set 7 04/20/23, 10:27