Review main Merged

78659[TASK] Return early in ContentObjectRenderer::cObjGet()

Oliver Hader CR +2 V +2 Easy +1 −1 updated 04/16/23, 08:06

Commit message

In case an empty array is passed to ContentObjectRenderer::cObjGet(),
the process returns early, without invoking any array processing and
variable assignments.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Christian Kuhn +1
    • Tymoteusz Motylewski +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Christian Kuhn +1
    • Tymoteusz Motylewski +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Oliver Hader uploaded patch set 1 04/15/23, 20:33

  2. core-ci voted on patch set 1 V +1 04/15/23, 20:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40709

  3. Christian Kuhn voted on patch set 1 V +1 CR +1 04/15/23, 21:11

  4. Tymoteusz Motylewski voted on patch set 1 V +1 CR +1 04/15/23, 21:52

  5. Oliver Hader voted on patch set 1 V +2 CR +2 04/16/23, 08:06

  6. Oliver Hader merged patch set 2 04/16/23, 08:06