Review main Merged

78661[TASK] Update display and markup of user settings form

Jasmina Ließmann CR +2 V +2 Normal +120 −105 updated 04/24/23, 18:15

Commit message

Previously, the form fields in user settings form were displayed in
their entirety, filling the screen.

With this patch, the width of the input mask is now reduced to create
a uniform appearance with forms of the form engine. Some individual
spacing between the form fields has also been adjusted to match those
of the form engine.

The buttons for adding or removing an avatar image now each contain
speaking labels that were previously only aria-labels.

Additionally, the form fields markup in the user settings has been
updated to fully match the FormEngine form field markup.
With this we create the prerequisite that rollouts of global style
adjustments for form fields also work on this form.
Mid-term, this module should be using FormEngine for rendering anyway,
so this is kind of a pre-patch.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 8