Review main Merged

78664[TASK] Add docheader buttons to CSP module

Chris Müller CR +2 V +2 Easy +45 −1 updated 11/29/24, 10:51

Commit message

The CSP module should at least provide the "Share" and "Reload"
buttons in docheader. Especially the "Reload" button is helpful
when testing and dealing with violations.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Josef Glatz +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Chris Müller +1
    • Josef Glatz +1
    • core-ci +1 CI

Issues 3

Files 3

Review log 2125

  1. Chris Müller uploaded patch set 1 04/16/23, 12:35

  2. core-ci voted on patch set 1 V +1 04/16/23, 12:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40737

  3. Oliver Hader commented on patch set 1 04/16/23, 13:07

    CspModuleController.php:79

    The csp-reports module fetches data only via AJAX. Maybe there's a way to emit an event which the csp-reports module could listen to.
  4. Chris Müller commented on patch set 1 04/16/23, 13:21

    CspModuleController.php:79 Reply

    You mean via JS?
  5. Chris Müller abandoned the change 11/18/24, 08:44

    Won't work on it anymore.
  6. Oliver Hader commented on patch set 1 11/18/24, 09:46

    Thanks for your work. I guess you would not mind if I would restore this change and finish it?
  7. Oliver Hader restored the change 11/18/24, 12:20

  8. Oliver Hader uploaded patch set 2 V +1 11/18/24, 12:20

  9. Oliver Hader uploaded patch set 3 11/18/24, 12:26

  10. Oliver Hader commented on patch set 3 11/18/24, 12:26

    CspModuleController.php:79 Reply

    Done
  11. core-ci voted on patch set 2 V -1 11/18/24, 12:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69591

  12. Oliver Hader voted on patch set 3 CR +1 V +1 11/18/24, 12:29

  13. core-ci voted on patch set 3 V +1 11/18/24, 12:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69592

  14. Simon Schaufelberger voted on patch set 3 CR +1 V +1 11/18/24, 12:46

  15. Josef Glatz voted on patch set 3 V +1 11/18/24, 13:11

  16. Josef Glatz voted on patch set 3 CR +1 11/18/24, 13:18

  17. Benni Mack voted on patch set 3 CR +1 11/18/24, 13:21

  18. Christian Kuhn uploaded patch set 4 CR +1 V +1 11/18/24, 17:05

  19. Christian Kuhn commented on patch set 4 CR +1 V +1 11/18/24, 17:06

    let's get this done ... i tested and reviewed successfully and only removed v12 from the backport list since i'd consider this change too late for old stable.
  20. core-ci voted on patch set 4 V +1 11/18/24, 17:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69610

  21. Josef Glatz voted on patch set 4 CR +1 V +1 11/18/24, 17:44

  22. Chris Müller voted on patch set 4 V +1 11/18/24, 18:59

  23. Christian Kuhn voted on patch set 4 CR +2 V +2 11/18/24, 19:10

  24. Christian Kuhn merged patch set 5 11/18/24, 19:10

  25. Oliver Hader wrote 11/29/24, 10:51

    Topic set to csp