Review 11.5 Merged

78672[BUGFIX] Set 'typoLinkParameter' array index for error handling

Stefan Bürk CR +2 V +2 Easy +20 −0 updated 04/16/23, 19:49

Commit message

Set the array index `$linkDetails['typoLinkParameter']` in
`\TYPO3\CMS\Redirects\Service\RedirectService` to pass it
through. That information is needed for the LinkBuilder.

For example, `DatabaseRecordLinkBuilder` would trigger an
array key access error, in case the linked record cannot
be found and no link can be generated. This array value
is use there for the thrown exception message.

The team play between `LinkService->resolve()` and the
`LinkBuilder->build()` should be reviewed in a dedicated
change. It may be useful, that the resolver directly
adds this information to the result, making the manual
adding at several placed through out the core obsolete.
Comments are added to document this.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 4

Review log 34

  1. Stefan Bürk uploaded patch set 1 04/16/23, 19:22

  2. core-ci voted on patch set 1 V +1 04/16/23, 19:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40766

  3. Stefan Bürk voted on patch set 1 V +2 CR +2 04/16/23, 19:48

  4. Stefan Bürk merged patch set 2 04/16/23, 19:49