Review main Merged

78716[BUGFIX] Wait for document being ready before booting form editor

Andreas Kienast CR +2 V +2 Easy +23 −18 updated 04/18/23, 08:53

Commit message

In some scenarios, it may happen that the DOM isn't ready while the
form editor is already booted, leading to JavaScript errors as DOM
nodes are not available yet.

The `dispatch*` methods in EXT:form's helper now wait for a ready state
before booting the form editor.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 68

  1. Andreas Kienast uploaded patch set 1 04/18/23, 07:10

  2. core-ci voted on patch set 1 V +1 04/18/23, 07:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40847

  3. Christian Kuhn commented on patch set 1 04/18/23, 07:41

    nice. fixes my loading issue.
  4. Andreas Kienast updated the commit message in patch set 2 V +1 04/18/23, 07:57

  5. core-ci voted on patch set 2 V +1 04/18/23, 08:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40850

  6. Christian Kuhn commented on patch set 2 V +1 CR +1 04/18/23, 08:12

    Ok. Andy created this patch blindly: He isn't able to reproduce the issue. This is a race condition, and it seems to happen only on "quick" instances. I'm able to reproduce the issue (local instance, quick system) about ~50% of the time. I confirm the issue is fixed with the patch.
  7. Benni Mack voted on patch set 2 V +2 CR +2 04/18/23, 08:53

  8. Benni Mack merged patch set 3 04/18/23, 08:53