Review main Merged

78717[BUGFIX] `ceil()` dimensions in CropperEvent

Andreas Kienast CR +2 V +2 Easy +3 −3 updated 04/20/23, 13:55

Commit message

The dimensions available in `CropperEvent` are fractions in some cases,
that probably happens when an image gets upscaled. This causes issues
as those dimensions are apparently adjusted downward in the cropper
library, resulting in dimension reduced by 1px. To solve this issue,
`Math.ceil()` is applied to round up incoming dimensions.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Christian Kuhn +1
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Christian Kuhn +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 78

  1. Andreas Kienast uploaded patch set 1 04/18/23, 07:36

  2. core-ci voted on patch set 1 V +1 04/18/23, 07:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40849

  3. Benni Mack voted on patch set 1 V +1 CR +1 04/19/23, 11:09

  4. Benni Mack commented on patch set 1 04/19/23, 11:09

    image-manipulation.ts:451

    FYI. we used Math.floor() below
  5. Benni Mack commented on patch set 1 04/19/23, 11:09

    image-manipulation.ts:451 Reply

    Done
  6. Christian Kuhn voted on patch set 1 V +1 CR +1 04/20/23, 13:54

  7. Andreas Kienast voted on patch set 1 V +2 CR +2 04/20/23, 13:55

  8. Andreas Kienast merged patch set 2 04/20/23, 13:55