Review main Merged

78718[BUGFIX] Pass markup as fragment in `debugInPopUpWindow()`

Andreas Kienast CR +2 V +2 Easy +1 −1 updated 04/18/23, 13:39

Commit message

The method `DebugUtility::debugInPopUpWindow()` renders a modal with
a debug dump, if applicable. The content will always contain markup,
which is rendered as plain text in the modal, was intended by the modal
component.

To have the dump correctly rendered, the markup is passed as a fragment
to the modal component.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Andreas Kienast uploaded patch set 1 04/18/23, 08:02

  2. core-ci voted on patch set 1 V +1 04/18/23, 08:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40851

  3. Oli Bartsch voted on patch set 1 V +1 CR +1 04/18/23, 09:13

  4. Christian Kuhn voted on patch set 1 V +1 CR +1 04/18/23, 13:37

  5. Andreas Kienast voted on patch set 1 V +2 CR +2 04/18/23, 13:39

  6. Andreas Kienast merged patch set 2 04/18/23, 13:39