Review 10.4 Abandoned

78721[BUGFIX] Restore correct context after redirect evaluation

Markus Klein CR 0 V 0 Easy +16 −0 updated 04/18/23, 15:43

Commit message

Remove any modification done to Context by the RedirectHandler/RedirectService
in order to have a proper rendering of FE in case no valid redirect is found (circular).

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 45

  1. Markus Klein uploaded patch set 1 04/18/23, 08:38

  2. core-ci voted on patch set 1 V +1 04/18/23, 08:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40854

  3. Christian Kuhn commented on patch set 1 04/18/23, 13:39

    you pushed a 10.4, but did not note that in commit message. is this change so important that we really must include this in v10?
  4. Markus Klein commented on patch set 1 CR -1 04/18/23, 15:42

    Won't be merged for v10

    Reply

    I talked with Benni about this meanwhile. I pushed the v10 backport because we initially fixed this for v10 on our project. If somebody needs the backport, it is here now. I deliberately only declared it to be fixed for v11 and v12 though. I will abandon this review for v10 now.
  5. Markus Klein abandoned the change 04/18/23, 15:43

    Will not be part of v10 anymore