Review main Merged

78723[BUGFIX] Prevent type errors in ExportController

Oli Bartsch CR +2 V +2 Easy +13 −11 updated 04/18/23, 12:33

Commit message

In case an export is created based on e.g.
an invalid preset, no PHP TypeError should
be occure.

This is now fixed by properly typecasting
the input data.

Additionally, two possible undefined array
key access warnings are fixed.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Jochen Roth +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Benni Mack +2
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 56

  1. Oli Bartsch uploaded patch set 1 04/18/23, 09:06

  2. core-ci voted on patch set 1 V +1 04/18/23, 09:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40856

  3. Jochen Roth voted on patch set 1 V +1 CR +1 04/18/23, 09:34

  4. Oliver Klee voted on patch set 1 CR +1 04/18/23, 10:57

  5. Benni Mack voted on patch set 1 V +2 CR +2 04/18/23, 12:33

  6. Benni Mack merged patch set 2 04/18/23, 12:33