Review main Merged

78724[BUGFIX] Handle objects as key in DebuggerUtility

Oli Bartsch CR +2 V +2 Easy +2 −1 updated 04/18/23, 11:21

Commit message

Due to the TYPO3\CMS\Core\Type\Map implementation,
the key of a collection entry can also be an object.

This is now handled properly in DebuggerUtility.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Oliver Klee +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 67

  1. Oli Bartsch uploaded patch set 1 04/18/23, 09:23

  2. core-ci voted on patch set 1 V +1 04/18/23, 09:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40859

  3. Jochen Roth voted on patch set 1 V +1 CR +1 04/18/23, 09:36

  4. Oliver Klee voted on patch set 1 CR +1 04/18/23, 10:57

  5. Andreas Kienast voted on patch set 1 V +1 CR +1 04/18/23, 11:09

  6. Oli Bartsch voted on patch set 1 V +2 CR +2 04/18/23, 11:20

  7. Oli Bartsch merged patch set 2 04/18/23, 11:21