Review main Merged

78726[BUGFIX] Properly compare file extensions in ResourceFileExtensionMatcher

Oli Bartsch CR +2 V +2 Normal +83 −6 updated 04/18/23, 12:26

Commit message

It's now ensured that ResourceFileExtensionMatcher
properly compares  the file extensions using only
lowercase chars. Additionally, the in_array checks
are set to "strict".

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 79

  1. Oli Bartsch uploaded patch set 1 04/18/23, 11:12

  2. core-ci voted on patch set 1 V +1 04/18/23, 11:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40866

  3. Andreas Kienast commented on patch set 1 04/18/23, 11:30

    ResourceFileExtensionMatcher.php:42

    array_map(strtolower(...), $extensions)

    ResourceFileExtensionMatcher.php:59

    array_map(strtolower(...), $extensions)
  4. Oli Bartsch uploaded patch set 2 V +1 04/18/23, 12:04

  5. Oli Bartsch commented on patch set 2 04/18/23, 12:04

    ResourceFileExtensionMatcher.php:42 Reply

    Done

    ResourceFileExtensionMatcher.php:59 Reply

    Done
  6. Andreas Kienast voted on patch set 2 V +1 CR +1 04/18/23, 12:16

  7. core-ci voted on patch set 2 V +1 04/18/23, 12:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40868

  8. Benni Mack voted on patch set 2 V +2 CR +2 04/18/23, 12:25

  9. Benni Mack merged patch set 3 04/18/23, 12:26