78727[TASK] Deprecate BE/languageDebug
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Josef Glatz +1
- Georg Ringer +1
-
Verified V +2 Done
- Christian Kuhn +2
- Josef Glatz +1
- Georg Ringer +1
- core-ci +1 CI
Issues 1
Files 4
- typo3/sysext/core/Classes/Localization/LanguageService.php+13 −0
- typo3/sysext/core/Classes/Localization/LanguageServiceFactory.php+1 −0
- typo3/sysext/core/Documentation/Changelog/12.4/Deprecation-100657-TYPO3_CONF_VARSBElanguageDebug.rstnew+58 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/PropertyPublicMatcher.php+5 −0
Review log 89
-
Christian Kuhn uploaded patch set 1 04/18/23, 11:28
-
core-ci voted on patch set 1 V +1 04/18/23, 11:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40867
-
Georg Ringer commented on patch set 1 CR -2 04/18/23, 11:46
really don't like the rush 1 week before release. yes it clutters the backend but it is currently the only way to identify the labels used. an alternative could be to use the crowdin directly within the backend which I got as POC but as long as this is not super stable I don't like to remove the change -
Josef Glatz commented on patch set 1 V -1 CR -1 04/18/23, 11:51
I would not deprecate it until there is no real successor. According to Benni something new could be used in future for querying translations, but completely removing feels wrong to me. I often use it. I often have to use it, since we have strings which are duplicated many times AND often it's the only place to check from where this key is coming from in a normal amount of time! -
Josef Glatz commented on patch set 1 V +1 CR +1 04/18/23, 12:26
talked to lolli. by looking at the big picture this step looks necessary for further work on translation problems -
Georg Ringer voted on patch set 1 CR 0 04/18/23, 12:36
-
Georg Ringer voted on patch set 1 V +1 CR +1 04/18/23, 12:37
-
Christian Kuhn commented on patch set 1 V +2 CR +2 04/18/23, 12:54
talked with georg & josef: i promised to come up with something more solid in v13 when the bigger picture of a better api evolves. in case we don't get this done, we can still revert this patch and the according v13 removal patch relatively easily. -
Christian Kuhn merged patch set 2 04/18/23, 12:55