Review main Merged

78731[TASK] Deprecate ConfigurationManager->getContentObject()

Christian Kuhn CR +2 V +2 Normal +174 −34 updated 04/19/23, 14:30

Commit message

The extbase ConfigurationManager logic is still
painful. It is a stateful singleton, which
we can not dissolve at the moment.

To reduce headaches, we now deprecate the
getContentObject() misuse, a solution avoiding
this has been established with #100623.

This allows us to streamline the implementation
with TYPO3 v13 quite a bit, making it less of a
burden.

The patch deprecates the method and introduces a
setRequest() method instead. Extbase bootstrap
takes care of setting this for each plugin. We
don't get rid of the singleton state, but since
we don't add a public getRequest(), it makes
ConfigurationManager a data sink only for this
state, which can not be abused anymore.

This also allows us to get rid of
$GLOBALS['TYPO3_REQUEST'] usages within
ConfigurationManager in TYPO3 v13.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 6