Review main Merged

78752[TASK] Update ckeditor5 to v37.1

Andreas Kienast CR +2 V +2 Impossible +27354 −36856 updated 04/20/23, 12:19

Commit message

ckeditor5 was released in version 37.1 lately, being fully written in
TypeScript. Thanks to this, several `@types/*` packages can be removed.

However, due to how the "link" plugin is overriden, some `@ts-ignore`
statements have to be used for now.

Executed commands:

    npm uninstall \
        @types/ckeditor__ckeditor5-alignment \
        @types/ckeditor__ckeditor5-autoformat \
        @types/ckeditor__ckeditor5-basic-styles \
        @types/ckeditor__ckeditor5-block-quote \
        @types/ckeditor__ckeditor5-clipboard \
        @types/ckeditor__ckeditor5-code-block \
        @types/ckeditor__ckeditor5-core \
        @types/ckeditor__ckeditor5-editor-classic \
        @types/ckeditor__ckeditor5-engine \
        @types/ckeditor__ckeditor5-essentials \
        @types/ckeditor__ckeditor5-find-and-replace \
        @types/ckeditor__ckeditor5-heading \
        @types/ckeditor__ckeditor5-horizontal-line \
        @types/ckeditor__ckeditor5-html-support \
        @types/ckeditor__ckeditor5-indent \
        @types/ckeditor__ckeditor5-link \
        @types/ckeditor__ckeditor5-list \
        @types/ckeditor__ckeditor5-paste-from-office \
        @types/ckeditor__ckeditor5-remove-format \
        @types/ckeditor__ckeditor5-source-editing \
        @types/ckeditor__ckeditor5-special-characters \
        @types/ckeditor__ckeditor5-table \
        @types/ckeditor__ckeditor5-ui \
        @types/ckeditor__ckeditor5-undo \
        @types/ckeditor__ckeditor5-utils \
        @types/ckeditor__ckeditor5-word-count

    npm i --save \
        @ckeditor/ckeditor5-alignment@^37.1.0 \
        @ckeditor/ckeditor5-autoformat@^37.1.0 \
        @ckeditor/ckeditor5-basic-styles@^37.1.0 \
        @ckeditor/ckeditor5-block-quote@^37.1.0 \
        @ckeditor/ckeditor5-clipboard@^37.1.0 \
        @ckeditor/ckeditor5-code-block@^37.1.0 \
        @ckeditor/ckeditor5-core@^37.1.0 \
        @ckeditor/ckeditor5-dev-utils@^37.0.1 \
        @ckeditor/ckeditor5-editor-classic@^37.1.0 \
        @ckeditor/ckeditor5-engine@^37.1.0 \
        @ckeditor/ckeditor5-essentials@^37.1.0 \
        @ckeditor/ckeditor5-find-and-replace@^37.1.0 \
        @ckeditor/ckeditor5-heading@^37.1.0 \
        @ckeditor/ckeditor5-horizontal-line@^37.1.0 \
        @ckeditor/ckeditor5-html-support@^37.1.0 \
        @ckeditor/ckeditor5-indent@^37.1.0 \
        @ckeditor/ckeditor5-link@^37.1.0 \
        @ckeditor/ckeditor5-list@^37.1.0 \
        @ckeditor/ckeditor5-paragraph@^37.1.0 \
        @ckeditor/ckeditor5-paste-from-office@^37.1.0 \
        @ckeditor/ckeditor5-remove-format@^37.1.0 \
        @ckeditor/ckeditor5-source-editing@^37.1.0 \
        @ckeditor/ckeditor5-special-characters@^37.1.0 \
        @ckeditor/ckeditor5-style@^37.1.0 \
        @ckeditor/ckeditor5-table@^37.1.0 \
        @ckeditor/ckeditor5-theme-lark@^37.1.0 \
        @ckeditor/ckeditor5-ui@^37.1.0 \
        @ckeditor/ckeditor5-undo@^37.1.0 \
        @ckeditor/ckeditor5-utils@^37.1.0 \
        @ckeditor/ckeditor5-word-count@^37.1.0 \
        @typescript-eslint/eslint-plugin@^5.59.0 \
        @typescript-eslint/parser@^5.59.0 \
        @typescript-eslint/typescript-estree@^5.59.0

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 8

Review log 710

  1. Andreas Kienast uploaded patch set 1 04/19/23, 14:04

  2. Andreas Kienast uploaded patch set 2 04/19/23, 14:11

  3. Andreas Kienast uploaded patch set 3 04/19/23, 14:17

  4. Andreas Kienast uploaded patch set 4 04/19/23, 14:20

  5. core-ci voted on patch set 2 V +1 04/19/23, 14:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40903

  6. core-ci voted on patch set 1 V -1 04/19/23, 14:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40902

  7. core-ci voted on patch set 4 V +1 04/19/23, 14:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40905

  8. Benni Mack voted on patch set 4 V +1 CR +1 04/20/23, 11:31

  9. Georg Ringer voted on patch set 4 V +2 CR +2 04/20/23, 12:19

  10. Georg Ringer merged patch set 5 04/20/23, 12:19